Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rust build threads in CI #4853

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Fix rust build threads in CI #4853

merged 1 commit into from
Feb 5, 2025

Conversation

benjaminwinger
Copy link
Collaborator

Also fixed invalid lines in windows makefile (don't allow # comments and there was an export that shouldn't have been there)

The CARGO_BUILD_JOBS from the ci workflow was being overridden in the makefile using NUM_THREADS, which since it wasn't set, was defaulting to 1.

Also fixed invalid lines in windows makefile (don't allow # comments and there was an export that shouldn't have been there)
Copy link

github-actions bot commented Feb 5, 2025

Benchmark Result

Master commit hash: 80d4a48dad3fb66944c1bfc8d84aac8b4bc060a7
Branch commit hash: 5585af66cef407cdc12bd80c7525fe876a28a164

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 691.69 690.39 1.29 (0.19%)
aggregation q28 6440.51 6626.90 -186.39 (-2.81%)
filter q14 127.73 129.26 -1.53 (-1.18%)
filter q15 127.30 127.68 -0.38 (-0.30%)
filter q16 308.46 309.20 -0.73 (-0.24%)
filter q17 444.66 445.45 -0.78 (-0.18%)
filter q18 1940.58 1915.52 25.06 (1.31%)
filter zonemap-node 88.75 89.99 -1.23 (-1.37%)
filter zonemap-node-lhs-cast 89.39 89.62 -0.23 (-0.26%)
filter zonemap-node-null 89.42 89.21 0.21 (0.24%)
filter zonemap-rel 5452.34 5455.26 -2.92 (-0.05%)
fixed_size_expr_evaluator q07 573.35 571.56 1.79 (0.31%)
fixed_size_expr_evaluator q08 800.93 803.57 -2.64 (-0.33%)
fixed_size_expr_evaluator q09 802.57 802.82 -0.25 (-0.03%)
fixed_size_expr_evaluator q10 236.52 236.85 -0.34 (-0.14%)
fixed_size_expr_evaluator q11 228.92 229.56 -0.64 (-0.28%)
fixed_size_expr_evaluator q12 227.17 226.36 0.81 (0.36%)
fixed_size_expr_evaluator q13 1474.07 1476.19 -2.11 (-0.14%)
fixed_size_seq_scan q23 114.40 112.65 1.75 (1.56%)
join q29 644.53 636.84 7.70 (1.21%)
join q30 10738.97 9943.52 795.45 (8.00%)
join q31 7.36 7.81 -0.45 (-5.70%)
join SelectiveTwoHopJoin 54.38 58.69 -4.31 (-7.35%)
ldbc_snb_ic q35 2612.15 2654.64 -42.49 (-1.60%)
ldbc_snb_ic q36 475.31 477.22 -1.90 (-0.40%)
ldbc_snb_is q32 3.72 2.64 1.08 (40.85%)
ldbc_snb_is q33 15.55 15.07 0.48 (3.19%)
ldbc_snb_is q34 1.28 1.40 -0.12 (-8.38%)
multi-rel multi-rel-large-scan 1329.30 1347.02 -17.72 (-1.32%)
multi-rel multi-rel-lookup 17.32 19.14 -1.82 (-9.51%)
multi-rel multi-rel-small-scan 63.79 91.72 -27.93 (-30.45%)
order_by q25 130.94 128.59 2.35 (1.83%)
order_by q26 479.07 474.34 4.72 (1.00%)
order_by q27 1450.86 1452.23 -1.37 (-0.09%)
recursive_join recursive-join-bidirection 302.28 289.34 12.94 (4.47%)
recursive_join recursive-join-dense 7402.60 7385.82 16.78 (0.23%)
recursive_join recursive-join-path 23466.88 23416.35 50.53 (0.22%)
recursive_join recursive-join-sparse 1053.09 1059.76 -6.67 (-0.63%)
recursive_join recursive-join-trail 7366.77 7336.35 30.43 (0.41%)
scan_after_filter q01 172.39 172.83 -0.44 (-0.25%)
scan_after_filter q02 158.11 158.68 -0.56 (-0.36%)
shortest_path_ldbc100 q37 87.61 91.42 -3.81 (-4.17%)
shortest_path_ldbc100 q38 330.67 389.99 -59.32 (-15.21%)
shortest_path_ldbc100 q39 63.59 60.20 3.40 (5.64%)
shortest_path_ldbc100 q40 370.54 385.76 -15.22 (-3.95%)
var_size_expr_evaluator q03 2092.64 2101.33 -8.69 (-0.41%)
var_size_expr_evaluator q04 2238.13 2228.53 9.60 (0.43%)
var_size_expr_evaluator q05 2609.45 2602.77 6.69 (0.26%)
var_size_expr_evaluator q06 1325.58 1321.18 4.40 (0.33%)
var_size_seq_scan q19 1450.16 1459.69 -9.53 (-0.65%)
var_size_seq_scan q20 2377.23 2377.21 0.03 (0.00%)
var_size_seq_scan q21 2278.02 2285.25 -7.22 (-0.32%)
var_size_seq_scan q22 125.01 124.27 0.75 (0.60%)

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.41%. Comparing base (f75e6e9) to head (291ba31).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4853      +/-   ##
==========================================
- Coverage   86.41%   86.41%   -0.01%     
==========================================
  Files        1399     1399              
  Lines       60479    60479              
  Branches     7449     7450       +1     
==========================================
- Hits        52262    52261       -1     
- Misses       8048     8050       +2     
+ Partials      169      168       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger merged commit 6c5ec1f into master Feb 5, 2025
25 checks passed
@benjaminwinger benjaminwinger deleted the rust-ci branch February 5, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants