Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non exist pk error message #4883

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

acquamarin
Copy link
Collaborator

Fixes #4880
Give better error message when unable to find uuid primary key.

Copy link

Benchmark Result

Master commit hash: 7e3c70a708e9359a3cb3c336cad333738e5aed71
Branch commit hash: 5ad1b8354e956fbaef6710a5e391f6f3742e6fbc

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 724.37 715.60 8.76 (1.22%)
aggregation q28 6406.47 6388.20 18.27 (0.29%)
filter q14 126.19 117.94 8.25 (7.00%)
filter q15 128.12 116.23 11.89 (10.23%)
filter q16 303.44 297.31 6.13 (2.06%)
filter q17 444.95 439.71 5.23 (1.19%)
filter q18 1979.19 1899.77 79.42 (4.18%)
filter zonemap-node 88.38 80.80 7.59 (9.39%)
filter zonemap-node-lhs-cast 90.62 80.27 10.35 (12.89%)
filter zonemap-node-null 89.91 80.17 9.74 (12.14%)
filter zonemap-rel 5418.09 5474.48 -56.39 (-1.03%)
fixed_size_expr_evaluator q07 585.26 564.77 20.49 (3.63%)
fixed_size_expr_evaluator q08 820.22 795.20 25.02 (3.15%)
fixed_size_expr_evaluator q09 802.00 794.22 7.78 (0.98%)
fixed_size_expr_evaluator q10 237.23 228.25 8.98 (3.94%)
fixed_size_expr_evaluator q11 231.35 221.48 9.87 (4.46%)
fixed_size_expr_evaluator q12 228.70 218.14 10.55 (4.84%)
fixed_size_expr_evaluator q13 1465.76 1442.64 23.12 (1.60%)
fixed_size_seq_scan q23 112.67 104.26 8.40 (8.06%)
join q29 732.32 710.08 22.24 (3.13%)
join q30 10911.63 9989.00 922.63 (9.24%)
join q31 9.51 9.46 0.04 (0.46%)
join SelectiveTwoHopJoin 58.67 56.82 1.86 (3.27%)
ldbc_snb_ic q35 2669.79 2661.00 8.78 (0.33%)
ldbc_snb_ic q36 483.52 444.89 38.64 (8.68%)
ldbc_snb_is q32 6.59 6.84 -0.25 (-3.63%)
ldbc_snb_is q33 12.74 15.77 -3.02 (-19.18%)
ldbc_snb_is q34 1.22 1.29 -0.07 (-5.46%)
multi-rel multi-rel-large-scan 1343.46 1337.37 6.08 (0.45%)
multi-rel multi-rel-lookup 31.61 29.59 2.01 (6.80%)
multi-rel multi-rel-small-scan 83.57 52.74 30.83 (58.46%)
order_by q25 129.41 120.10 9.30 (7.75%)
order_by q26 450.67 445.46 5.21 (1.17%)
order_by q27 1438.01 1446.12 -8.11 (-0.56%)
recursive_join recursive-join-bidirection 295.55 301.10 -5.55 (-1.84%)
recursive_join recursive-join-dense 7466.91 7407.37 59.55 (0.80%)
recursive_join recursive-join-path 24426.24 24252.98 173.26 (0.71%)
recursive_join recursive-join-sparse 1052.01 1061.34 -9.33 (-0.88%)
recursive_join recursive-join-trail 7340.46 7352.03 -11.58 (-0.16%)
scan_after_filter q01 173.69 163.87 9.82 (5.99%)
scan_after_filter q02 157.45 149.33 8.12 (5.44%)
shortest_path_ldbc100 q37 98.80 89.60 9.20 (10.26%)
shortest_path_ldbc100 q38 372.56 395.40 -22.84 (-5.78%)
shortest_path_ldbc100 q39 64.54 65.31 -0.77 (-1.18%)
shortest_path_ldbc100 q40 410.88 452.43 -41.56 (-9.18%)
var_size_expr_evaluator q03 2119.11 2079.44 39.67 (1.91%)
var_size_expr_evaluator q04 2259.71 2223.12 36.59 (1.65%)
var_size_expr_evaluator q05 2661.27 2660.97 0.30 (0.01%)
var_size_expr_evaluator q06 1328.44 1339.44 -10.99 (-0.82%)
var_size_seq_scan q19 1455.94 1463.64 -7.70 (-0.53%)
var_size_seq_scan q20 2366.06 2334.18 31.88 (1.37%)
var_size_seq_scan q21 2278.66 2374.92 -96.25 (-4.05%)
var_size_seq_scan q22 126.03 126.07 -0.04 (-0.03%)

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.54%. Comparing base (b3f88d7) to head (4a663f8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4883   +/-   ##
=======================================
  Coverage   86.53%   86.54%           
=======================================
  Files        1403     1403           
  Lines       60536    60537    +1     
  Branches     7442     7442           
=======================================
+ Hits        52385    52390    +5     
+ Misses       7982     7978    -4     
  Partials      169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin merged commit afd089b into master Feb 11, 2025
27 checks passed
@acquamarin acquamarin deleted the fix-non-exist-pk-error-message branch February 11, 2025 14:50
acquamarin added a commit that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[COPY FROM] Bug: Error: Copy exception: Unable to find primary key value 1344455615... (given missing UUID)
2 participants