Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prompts): add commit message #508

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Feb 10, 2025

Important

Add commitMessage support for prompt versions in API and client interfaces.

  • Behavior:
    • Adds commitMessage field to prompt creation and fetching in langfuse-integration-fetch.spec.ts.
    • Updates OpenAPI spec in openapi-server.yaml to include commitMessage for prompt versions.
  • Models:
    • Adds commitMessage to BasePromptClient in promptClients.ts.
    • Updates ApiCreateChatPromptRequest and ApiCreateTextPromptRequest in publicApi.ts to include commitMessage.
  • Misc:
    • Updates components in server.ts to include commitMessage for prompt-related schemas.

This description was created by Ellipsis for b303a6e. It will automatically update as commits are pushed.

Greptile Summary

Disclaimer: Experimental PR review

Added support for commit messages in prompts across the Langfuse JS SDK, enabling better version tracking and documentation of prompt changes.

  • Added optional commitMessage field to prompt interfaces in /langfuse/src/publicApi.ts and OpenAPI specs
  • Added commitMessage property to BasePromptClient class in /langfuse-core/src/prompts/promptClients.ts
  • Added integration tests in /integration-test/langfuse-integration-fetch.spec.ts to verify commit message functionality
  • Note: commitMessage is missing from toJSON() method in BasePromptClient which could cause serialization inconsistencies

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langfuse-js ✅ Ready (Inspect) Visit Preview Feb 10, 2025 11:43am

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@hassiebp hassiebp merged commit fe83f14 into main Feb 10, 2025
9 checks passed
@hassiebp hassiebp deleted the hassieb/lfe-3915-prompt-commit-msg branch February 10, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant