Resolve runtime error with openai extension when metadata is missing #1115
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When store=True is passed to the chat.completions.create API, the metadata parameter is optional. In this case, the updated line of code fails to set an empty dictionary to self.kwargs["metadata"]. More specifically,
self.args["metadata"]
isNone
in the scenario.Important
Fixes runtime error in
get_openai_args()
inopenai.py
by settingmetadata
to{}
whenNone
andstore=True
.get_openai_args()
inopenai.py
whenmetadata
isNone
andstore=True
is passed tochat.completions.create
API.self.kwargs["metadata"]
to{}
ifself.args["metadata"]
isNone
.This description was created by
for 3ec9248. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Fixed a runtime error in the OpenAI extension where missing metadata caused failures when using the chat.completions.create API with store=True.
langfuse/openai.py
to handle None metadata by defaulting to empty dictionary💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!