🐛 Improve ERD auto-layout rendering with state-based approach #671
+33
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junkisai
requested review from
hoshinotsuyoshi,
FunamaYukina,
MH4GF and
sasamuku
and removed request for
a team
junkisai
force-pushed
the
fix/auto-layout-on-safari
branch
from
ac18674 to
323b16d
Compare
🦋 Changeset detectedLatest commit: 323b16d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
FunamaYukina
approved these changes
Feb 5, 2025
|
Awesome!! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed an issue in mobile Safari where the initial auto layout was not applied.
demo.mp4
The problem was caused by executing setInitializeComplete(true) and performing layout calculations before the nodes were updated by setNodes.
To resolve this, setInitializeComplete is now executed after setNodes has completed.
Related Issue
N/A
Changes
Testing
cli ver.
2025-02-05.11.52.39.mov
2025-02-05.11.54.35.mov
ScreenRecording_02-05-2025.11-59-23_1.MP4
ScreenRecording_02-05-2025.12-01-34_1.MP4
web ver.
2025-02-05.11.53.09.mov
2025-02-05.11.55.07.mov
ScreenRecording_02-05-2025.12-00-00_1.MP4
ScreenRecording_02-05-2025.12-03-04_1.MP4
Other Information