-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSX keyboard driver is missing support for the numeric pad "fullstop" key and the (EU) section sign (§) key #1523
Comments
dionoid
added a commit
to dionoid/allegro5
that referenced
this issue
Dec 24, 2023
* mapped numeric keypad's period/fullstop/delete key to ALLEGRO_KEY_PAD_DELETE * mapped section sign (§) key to ALLEGRO_KEY_UNKNOWN+0
For the record the key below Esc is mapped to TILDE for the US layout, and BACKSPACE with Norwegian layout on my Norwegian keyboard. This is on Windows. Someone with a US keyboard would have to verify the first one, but backspace makes little sense to me. The characters on that key are `~ in US layout, |§ in Norwegian. |
SiegeLord
added a commit
to SiegeLord/allegro5
that referenced
this issue
Nov 10, 2024
SiegeLord
added a commit
to SiegeLord/allegro5
that referenced
this issue
Nov 18, 2024
SiegeLord
pushed a commit
to SiegeLord/allegro5
that referenced
this issue
Nov 18, 2024
…y to ALLEGRO_KEY_BACKSLASH2 on MacOS. The first is uncontroversial. The second is unclear, but perhaps a decent choice? https://discussions.apple.com/thread/8133633?sortBy=rank says that the Usage ID of that key is 0x64. https://github.com/tmk/tmk_keyboard/wiki/USB:-HID-Usage-Table#note-9 says that that usage maps to the international backslash key. Not having a physical keyboard, I cannot confirm one way or another. One snag is that there's https://keyshorts.com/blogs/blog/37615873-how-to-identify-macbook-keyboard-localization#norwegian which has both the section key (in the top left) and the internaltional tab key (to the right of left shift). I don't know what the expectation for those keys, or what they code would do for them. Not having a physical keyboard, I cannot confirm one way or another. Still, perhaps this is a better situation than before, where the key was unmapped entirely. Fixes liballeg#1523.
SiegeLord
pushed a commit
to SiegeLord/allegro5
that referenced
this issue
Nov 18, 2024
…y to ALLEGRO_KEY_BACKSLASH2 on MacOS. The first is uncontroversial. The second is unclear, but perhaps a decent choice? https://discussions.apple.com/thread/8133633?sortBy=rank says that the Usage ID of that key is 0x64. https://github.com/tmk/tmk_keyboard/wiki/USB:-HID-Usage-Table#note-9 says that that usage maps to the international backslash key. Not having a physical keyboard, I cannot confirm one way or another. One snag is that there's https://keyshorts.com/blogs/blog/37615873-how-to-identify-macbook-keyboard-localization#norwegian which has both the section key (in the top left) and the internaltional tab key (to the right of left shift). I don't know what the expectation for those keys, or what they code would do for them. Not having a physical keyboard, I cannot confirm one way or another. Still, perhaps this is a better situation than before, where the key was unmapped entirely. Fixes liballeg#1523.
SiegeLord
pushed a commit
to SiegeLord/allegro5
that referenced
this issue
Nov 18, 2024
…y to ALLEGRO_KEY_BACKSLASH2 on MacOS. The first is uncontroversial. The second is unclear, but perhaps a decent choice? https://discussions.apple.com/thread/8133633?sortBy=rank says that the Usage ID of that key is 0x64. https://github.com/tmk/tmk_keyboard/wiki/USB:-HID-Usage-Table#note-9 says that that usage maps to the international backslash key. Not having a physical keyboard, I cannot confirm one way or another. One snag is that there's https://keyshorts.com/blogs/blog/37615873-how-to-identify-macbook-keyboard-localization#norwegian which has both the section key (in the top left) and the internaltional tab key (to the right of left shift). I don't know what the expectation for those keys, or what they code would do for them. Not having a physical keyboard, I cannot confirm one way or another. Still, perhaps this is a better situation than before, where the key was unmapped entirely. Fixes liballeg#1523.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While the keyboard drivers for Windows, Linux, X and SDL map the numeric keypad's period/fullstop/delete key to ALLEGRO_KEY_PAD_DELETE, the OSX driver maps it to ALLEGRO_KEY_FULLSTOP. I think this is incorrect and makes it impossible to distinguish between the period/fullstop key on the main keyboard and the one on the numeric keypad.

My suggestion is to map this key on OSX to ALLEGRO_KEY_PAD_DELETE, the same way as the other OS's do.
Also on OSX, the Section Sign key (§) - which on European Mac keyboards is located below the Escape key - isn't currently mapped.

My suggestion is to map this key to ALLEGRO_KEY_UNKNOWN+0, so al least its key press can be handled.
I'll create a PR if that's OK.
The text was updated successfully, but these errors were encountered: