Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parseRequest route equals composition compareator #1097

Closed
nadar opened this issue Dec 6, 2016 · 0 comments
Closed

Remove parseRequest route equals composition compareator #1097

nadar opened this issue Dec 6, 2016 · 0 comments
Assignees
Milestone

Comments

@nadar
Copy link
Contributor

nadar commented Dec 6, 2016

Remove from luya\web\UrlManager in parseRequest().

// route matches composition exactly, so we have to remove the composition informations
        if ($route === $composition) {
            $parsedRequest[0] = false;
        // now see if the composition (+1 as we add add trailing slash at the end) matches the cutted route request part, if so its composition prefix, remove it.
        } 
     // keep this part
    elseif (substr($route, 0, $length+1) == $composition.'/') { // ...

As the composition will already be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant