Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kenny/futr 164 update cli to dynamically set docker compose file #140

Conversation

abhiaiyer91
Copy link
Contributor

  • feat: replace container name with user's project name
  • feat: cli update to port
  • Rewrite

Copy link

linear bot commented Aug 22, 2024

FUTR-164 Update CLI to dynamically set docker compose file

Inngest and db should be based on the project name of the apps package.json from where the CLI command is run.

This should also dynamically find a port number (perhaps within a specified range) that is open so it is unique.

Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
arkwright-admin ❌ Failed (Inspect) Aug 22, 2024 6:26pm

@calcsam
Copy link
Contributor

calcsam commented Aug 22, 2024

I'm getting the following error. Should we replace / with - in getProjectName? @adeleke5140

 ✔ Volume "cli_pgdata"  Created                                                                                                                                                                                                0.0s
 ⠋ Container db         Recreate                                                                                                                                                                                               0.0s
 ⠋ Container inngest    Recreate                                                                                                                                                                                               0.0s
Error response from daemon: Invalid container name (c5c58d966c01_@arkw/cli-db), only [a-zA-Z0-9][a-zA-Z0-9_.-] are allowed
Failed to start Docker containers: ExecaError: Command failed with exit code 1: docker compose up -d
    at getFinalError (file:///Users/samuelbhagwat/workspace/future/node_modules/.pnpm/[email protected]/node_modules/execa/lib/return/final-error.js:6:9)
    at makeError (file:///Users/samuelbhagwat/workspace/future/node_modules/.pnpm/[email protected]/node_modules/execa/lib/return/result.js:108:16)
    at getAsyncResult (file:///Users/samuelbhagwat/workspace/future/node_modules/.pnpm/[email protected]/node_modules/execa/lib/methods/main-async.js:167:4)
    at handlePromise (file:///Users/samuelbhagwat/workspace/future/node_modules/.pnpm/[email protected]/node_modules/execa/lib/methods/main-async.js:150:17)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  shortMessage: 'Command failed with exit code 1: docker compose up -d',
  command: 'docker compose up -d',
  escapedCommand: 'docker compose up -d',

@abhiaiyer91
Copy link
Contributor Author

I'm getting the following error. Should we replace / with - in getProjectName? @adeleke5140

 ✔ Volume "cli_pgdata"  Created                                                                                                                                                                                                0.0s
 ⠋ Container db         Recreate                                                                                                                                                                                               0.0s
 ⠋ Container inngest    Recreate                                                                                                                                                                                               0.0s
Error response from daemon: Invalid container name (c5c58d966c01_@arkw/cli-db), only [a-zA-Z0-9][a-zA-Z0-9_.-] are allowed
Failed to start Docker containers: ExecaError: Command failed with exit code 1: docker compose up -d
    at getFinalError (file:///Users/samuelbhagwat/workspace/future/node_modules/.pnpm/[email protected]/node_modules/execa/lib/return/final-error.js:6:9)
    at makeError (file:///Users/samuelbhagwat/workspace/future/node_modules/.pnpm/[email protected]/node_modules/execa/lib/return/result.js:108:16)
    at getAsyncResult (file:///Users/samuelbhagwat/workspace/future/node_modules/.pnpm/[email protected]/node_modules/execa/lib/methods/main-async.js:167:4)
    at handlePromise (file:///Users/samuelbhagwat/workspace/future/node_modules/.pnpm/[email protected]/node_modules/execa/lib/methods/main-async.js:150:17)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  shortMessage: 'Command failed with exit code 1: docker compose up -d',
  command: 'docker compose up -d',
  escapedCommand: 'docker compose up -d',

updated

@abhiaiyer91 abhiaiyer91 merged commit 26cc3d8 into main Aug 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants