Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct starscream dependency minimum version to 4.0.5 #188

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

bradleyrzeller
Copy link
Contributor

My project was resolving to 4.0.4 of starscream which I found to be incompatible with v5.1 of swift-graphql. This PR simply updates to the min version starscream version accordingly.

The following breaking changes were made in v4.0.5 of starscream:

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swift-graphql ❌ Failed (Inspect) Nov 6, 2023 11:21pm

Copy link
Collaborator

@shaps80 shaps80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@maticzav maticzav merged commit 778b5ec into maticzav:main Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants