Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing RSS feed, update zola #2632

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

kilimnik
Copy link

I noticed that the templates include an rss.xml definition, though you are not using it. The default zola behaviour is to use the atom.xml, so I updated the config.toml to use both.

I also changed generate_feed to generate_feeds as this is the new option which should be used with the new version.

As this is a new zola feature, I also decided to update zola to the newest version.

Signed-off-by: Daniel Kilimnik <[email protected]>
Signed-off-by: Daniel Kilimnik <[email protected]>
Signed-off-by: Daniel Kilimnik <[email protected]>
@MTRNord
Copy link
Collaborator

MTRNord commented Feb 14, 2025

@thibaultamartin what version does cloudflare currently use? :) We obviously cant merge this if our cloudflare deployment doesnt support it yet.

@kilimnik
Copy link
Author

@thibaultamartin what version does cloudflare currently use? :) We obviously cant merge this if our cloudflare deployment doesnt support it yet.

You are uploading the built html page to cloudflare. The zola build process is running inside the GitHub Actions

@MTRNord
Copy link
Collaborator

MTRNord commented Feb 14, 2025

@thibaultamartin what version does cloudflare currently use? :) We obviously cant merge this if our cloudflare deployment doesnt support it yet.

You are uploading the built html page to cloudflare. The zola build process is running inside the GitHub Actions

Its a little more difficult than that in reality since we also use the preview feature of cloudflare which is built on the side of cloudflare instead :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants