This repository has been archived by the owner on Jun 28, 2018. It is now read-only.
driver/mysql: use go-sql-driver's multistatements #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that you've been looking into using mymysql instead of
go-sql-driver, but I don't think that this seems as a too big change. I
have some questions though:
driver url or should I parse the URL and ensure that it's defined to
be true in the query string?
may break other people's flow/code
to driverUrls, setting multiStatements=true). Should I commit this
change as well?
suggest testing both cases)
Any feedback is very appreciated.
The change is related to #1.