-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update XSLTs for new Presentation XML format #418
Comments
With the new Presentation XML refactor coming out of metanorma/isodoc#617, metanorma-iso now breaks on trying to test for STS conversion. Should I remove that integration testing, or keep it? |
Please keep it, I'm going to update |
Currently, Does the generation STS XML to MN XML directly make sense? In which scenarios it can be used? Metanorma XML can be generated in this workflow:
Could it be to drop the ISO/NISO STS to Metanorma XML conversion in @ronaldtse @opoudjis any thoughts on this? |
@opoudjis |
mnconvert is updated to 1.65.0 on my side, but STS generation is still crashing when running rspec in metanorma-iso:
|
Confirmed. I'll fix. |
mn2xml xslt updated to fix validation issue, #418
@opoudjis |
I'm sorry to say I don't have the business context for STS XML > MN XML conversion, but I agree with you that using Asciidoc as an intermediary representation makes much more sense, and I've argued for it for years in comparable contexts, for the same reason you've given: the XML may be more expressive and more formal, but it is also volatile and will remain so. The Asciidoc is simply more stable. |
@Intelligent2013 yes indeed. We can drop the STS to MN XML conversion. It's more important that we focus on what users need, which is in this use case, the ability to re-edit and re-publish STS XML. |
The ST4S apparently needs to be updated for Presentation XML for terms as well, the conversion is breaking in metanorma-iso
in spec/metanorma/processor_spec.rb, line 161 |
A week ago I've tested on ISO Rice document and the STS output XML was ok. |
mn2xml.xsl updated for new term tags, #418
Issue fixed in https://github.com/metanorma/mnconvert/releases/tag/v1.67.0. |
Source XML - new Presentation XML format without Semantic part Validation issues:
|
In the output NISO XML found the missing tags for the terms references. For instance, in the source BSI document (https://github.com/metanorma/mn-samples-bsi/tree/main/sources/bs-202000), in
The Presentation XML contains the plain text only:
Previously, the Semantic part (which used as 'base' for the conversion) contained this markup: <semantic__p id="semantic___34c2a109-0b03-f25c-efc8-7ba7fd222919">SM is a through-life <semantic__concept><semantic__refterm>process</semantic__refterm><semantic__renderterm>process</semantic__renderterm><semantic__xref target="semantic__term-process"/></semantic__concept> that enables the drafting, development and maintenance of <semantic__concept><semantic__refterm>standard</semantic__refterm><semantic__renderterm>standards</semantic__renderterm><semantic__xref target="semantic__term-standard"/></semantic__concept>. It promotes the intelligent selection and implementation of <semantic__concept><semantic__refterm>standard</semantic__refterm><semantic__renderterm>standards</semantic__renderterm><semantic__xref target="semantic__term-standard"/></semantic__concept>, policy, <semantic__concept><semantic__refterm>process</semantic__refterm><semantic__renderterm>processes</semantic__renderterm><semantic__xref target="semantic__term-process"/></semantic__concept> and tools, and delivers:</semantic__p> I'll add the issue in the |
There is one remaining issue I will create after Monday's release: refactoring of footnotes. There may be other requests as @strogonoff starts using the refactored code, but after that issue, this task can be treated as completed. |
@opoudjis what's the plan for footnotes? Placing them in a unified container per document? Ideally we separate footnote content and applicable locality, in order to allow shared footnotes (and differentiation in locality). |
|
version
because Metanorma docker updated 30 days ago: https://hub.docker.com/r/metanorma/metanorma. |
XSLT updated for old XML to STS XML conversion and validation. |
As titled.
Source issues:
The text was updated successfully, but these errors were encountered: