Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy tags if we create new Activity in ASP.NET Core listener #1660

Merged
merged 3 commits into from
Jan 31, 2020

Conversation

lmolkova
Copy link
Member

Changes

Some tags could be populated by users or 1P libraries (codex) on the Activity created by ASP.NET Core.

In some cases we drop this activity to substitute it with proper one (e.g. when we know W3C is not supported by the ASP.NET Core based on version). In this case we need to copy tags as well.

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@lmolkova lmolkova force-pushed the lmolkova/fixTagsPropagationForCustomActivities branch from 2730ba4 to cf1479e Compare January 31, 2020 07:02
@lmolkova lmolkova merged commit 7116e54 into develop Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants