Fix heartbeat for short-running WorkerServices #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
304NotModified
changed the title
304NotModified
changed the title
304NotModified
changed the title
|
How could I get this one reviewed? |
pharring
reviewed
Dec 14, 2024
| get => this.firstInterval; | ||
| set | ||
| { | ||
| this.firstInterval = value; |
There was a problem hiding this comment.
Add some bounds checking? At least make sure it's not negative (less than TimeSpan.Zero)
304NotModified
commented
Jan 20, 2025
| /// <summary> | ||
| /// Gets or sets the currently defined interval of the first heartbeat. Defaults to 1 second. | ||
| /// </summary> | ||
| public TimeSpan HeartbeatFirstInterval |
There was a problem hiding this comment.
Initial... Is maybe a better term
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the heartbeat by sending the first heartbeat af 1 second instead of 30.
This is configurable
Fixes #2759
Checklist
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for reviewers:
/AzurePipelines runwill queue all builds/AzurePipelines run <pipeline-name>will queue a specific build