Update Core Subnets Creation and upgrade core Terraform to 4.14.0

[ShakutaiGit]

What is being addressed

Summary of Main Changes:

1. Terraform Provider Upgrade

   • The AzureRM provider is upgraded from version 3.117.0 to 4.14.0, adjusting various Terraform files and lock files accordingly.

2. Network Subnets Refactor

   • Subnets are now defined inline within the azurerm_virtual_network resource instead of using separate azurerm_subnet resources.
   • Network Security Group (NSG) associations are handled through the security_group property directly in each subnet block, removing the need for individual azurerm_subnet_network_security_group_association resources.
   • Outputs now reference subnet IDs through a local.subnet_ids_map rather than separate subnet resources.

3. Migration Added

Testing
These changes were validated by:

• Creating a new Azure TRE environment.
• Deploying a workspace and a Guacamole VM.
• Adding a fabric service and confirming that the Guacamole VM could successfully access fabric.
• Upgrade test on the ci can be found here
  https://github.com/microsoft/AzureTRE/actions?query=branch%3Atest-main
• CI test from scratch https://github.com/microsoft/AzureTRE/actions/runs/13260768399

[github-actions]

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit a24ae1b.

♻️ This comment has been updated with latest results.

[ShakutaiGit]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12637008228 (with refid 1112296b)

(in response to this comment from @ShakutaiGit)

[marrobi]

Blocking this to ensure it doesn't get merged without upgrade considerations. But supportive if it works.

[ShakutaiGit]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12648030988 (with refid 1112296b)

(in response to this comment from @ShakutaiGit)

[ShakutaiGit]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12649874700 (with refid 1112296b)

(in response to this comment from @ShakutaiGit)

[ShakutaiGit]

/help

[github-actions]

🤖 pr-bot 🤖

Hello!

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @ShakutaiGit)

[ShakutaiGit]

/test-destroy-env

[github-actions]

Destroying PR test environment (RG: rg-tre1112296b)... (run: https://github.com/microsoft/AzureTRE/actions/runs/12655217007)

[github-actions]

Destroying branch test environment (RG: rg-tre1dfa8de5)... (run: https://github.com/microsoft/AzureTRE/actions/runs/12655217007)

[github-actions]

Branch test environment destroy complete (RG: rg-tre1dfa8de5)

[github-actions]

PR test environment destroy complete (RG: rg-tre1112296b)

[ShakutaiGit]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12656026868 (with refid 1112296b)

(in response to this comment from @ShakutaiGit)

[ShakutaiGit]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12656575532 (with refid 1112296b)

(in response to this comment from @ShakutaiGit)

[github-actions]

PR test environment destroy complete (RG: rg-tre1112296b)

[ShakutaiGit]

/test

[github-actions]

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13242610159 (with refid 1112296b)

(in response to this comment from @ShakutaiGit)

[ShakutaiGit]

/test

[github-actions]

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13244671813 (with refid 1112296b)

(in response to this comment from @ShakutaiGit)

[LizaShak]

LGTM. Following our online review everything looks good. Great job!

[marrobi]

Please wait until I've finished testing manually.

[marrobi]

LGTM, tested upgrade locally.

[marrobi]

/test-force-approve

already tested

[github-actions]

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit a24ae1b)

(in response to this comment from @marrobi)