Fix Cosmos DB local debugging #4340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…robi/add-cosmos-data-contributor
Unit Test Results608 tests 608 ✅ 6s ⏱️ Results for commit 5bb2154. ♻️ This comment has been updated with latest results. |
…robi/add-cosmos-data-contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- devops/scripts/setup_local_debugging.sh: Language not supported
Comments suppressed due to low confidence (3)
api_app/api/dependencies/database.py:29
- The removal of the dynamic key fetching logic using CosmosDBManagementClient means that the key must always be available in the configuration. This could cause issues if the key is not provided.
if STATE_STORE_KEY:
api_app/api/dependencies/database.py:47
- The removal of the MANAGED_IDENTITY_CLIENT_ID check might affect the behavior if the managed identity is required but not explicitly checked.
credential = await get_credential_async()
api_app/api/dependencies/database.py:29
- Ensure that the new connection logic, especially the use of STATE_STORE_KEY and managed identity, is covered by tests.
if STATE_STORE_KEY:
marrobi
changed the title
yuvalyaron
approved these changes
Feb 16, 2025
yuvalyaron
reviewed
Feb 16, 2025
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13367437668 (with refid (in response to this comment from @marrobi) |
|
/test-force-approve https://github.com/microsoft/AzureTRE/actions/runs/13367437668 |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 5bb2154) (in response to this comment from @marrobi) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce functionality to assign the Cosmos DB Built-in Data Contributor role when configuring local debugging to so that cosmos data can be read.
Always use Entra ID credentials unless a key is manually specified.