Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoPE fp16 avx #23772

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

RoPE fp16 avx #23772

wants to merge 5 commits into from

Conversation

liqunfu
Copy link
Contributor

@liqunfu liqunfu commented Feb 21, 2025

Description

Motivation and Context

Signed-off-by: liqunfu <[email protected]>
@liqunfu liqunfu requested a review from a team as a code owner February 21, 2025 03:25
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Comment on lines 61 to 63
//
class RoPEShortExecuteTest : public MlasTestFixture<MlasRoPETest> {
template<typename T>
class RoPEShortExecuteTest : public MlasTestFixture<MlasRoPETest<T>> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//
class RoPEShortExecuteTest : public MlasTestFixture<MlasRoPETest> {
template<typename T>
class RoPEShortExecuteTest : public MlasTestFixture<MlasRoPETest<T>> {
//
template <typename T>
class RoPEShortExecuteTest : public MlasTestFixture<MlasRoPETest<T>> {

liqunfu and others added 4 commits February 20, 2025 20:47
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: liqunfu <[email protected]>
Signed-off-by: liqunfu <[email protected]>
Comment on lines +291 to +294
//const auto* input_impl = reinterpret_cast<const float*>(input);
//const auto* sin_impl = reinterpret_cast<const float*>(sin_data);
//const auto* cos_impl = reinterpret_cast<const float*>(cos_data);
//auto* output_impl = reinterpret_cast<float*>(output);

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant