Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dropna limitation of quote_df of Exchange #1333

Closed
wants to merge 2 commits into from
Closed

Remove Dropna limitation of quote_df of Exchange #1333

wants to merge 2 commits into from

Conversation

you-n-g
Copy link
Collaborator

@you-n-g you-n-g commented Oct 30, 2022

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@you-n-g you-n-g requested a review from lihuoran October 30, 2022 10:48
@you-n-g
Copy link
Collaborator Author

you-n-g commented Oct 30, 2022 •
edited
Loading

Hi, @lihuoran Is this enough to remove the fill_missing_data in #1332 ?

@you-n-g you-n-g mentioned this pull request Oct 30, 2022
Merged
5 tasks
@you-n-g
Copy link
Collaborator Author

you-n-g commented Oct 30, 2022

MARK:
The backtest result of qrun benchmarks/LightGBM/workflow_config_lightgbm_Alpha158.yaml does not change

@you-n-g
Copy link
Collaborator Author

you-n-g commented Oct 30, 2022

@lihuoran The CI fails when it tests the RL part.
It may conflict with #1332 fill_missing_values.
Maybe we should cherry-pick this PR and test it with #1332 together.

@you-n-g you-n-g mentioned this pull request Oct 30, 2022
Merged
5 tasks
@you-n-g you-n-g closed this Oct 30, 2022
@you-n-g
Copy link
Collaborator Author

you-n-g commented Oct 30, 2022

The merge target is changed to microsoft:huoran/fix_rl_todos
The new PR is #1334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihuoran lihuoran Awaiting requested review from lihuoran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@you-n-g