-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS error stays around #12798
Comments
I will investigate, but the trace shows that an error is still reported by the tsserver. There is little we can do if this is the case. |
OK. The problem was that I still called realpath however the workbench and other parts didn't. After fixing this renaming back and forth works. @chrmarti can you please verify on Mac. |
Reopening the issue. Even with the fix I can still reproduce this under Mac. TS bug to track: microsoft/TypeScript#11206 |
However Windows looks good if both files are open. If only app.ts is open and bar.ts is renamed then things fail as well. |
This is getting more wired. Now I can reproduce this on Windows as well. |
Moving to October. There is nothing I can do today. More fixing requires a TS update. |
This got fixed with the latest upgrade to TS 2.0.6 were we now use one inferred project. |
Testing #12633
Steps to Reproduce:
[Info - 10:32:20 AM] Using tsserver from location: /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/server/typescript/lib/tsserver.js
[Trace - 10:32:20 AM] Sending request: open (0). Response expected: no. Current queue length: 0
Arguments: {
"file": "/Users/chrmarti/Development/repos/ts203/app.ts",
"fileContent": "import * as bar from './bar';\n\nbar.boo();\n"
}
[Trace - 10:32:20 AM] Sending request: open (1). Response expected: no. Current queue length: 0
Arguments: {
"file": "/Users/chrmarti/Development/repos/ts203/bar.ts",
"fileContent": "export function boo() {\n console.log('boo');\n}\n"
}
[Trace - 10:32:20 AM] Sending request: geterr (2). Response expected: no. Current queue length: 0
Arguments: {
"delay": 0,
"files": [
"/Users/chrmarti/Development/repos/ts203/app.ts",
"/Users/chrmarti/Development/repos/ts203/bar.ts"
]
}
[Trace - 10:32:21 AM] Event received: syntaxDiag (0).
Data: {
"file": "/Users/chrmarti/Development/repos/ts203/app.ts",
"diagnostics": []
}
[Trace - 10:32:21 AM] Event received: semanticDiag (0).
Data: {
"file": "/Users/chrmarti/Development/repos/ts203/app.ts",
"diagnostics": []
}
[Trace - 10:32:21 AM] Event received: syntaxDiag (0).
Data: {
"file": "/Users/chrmarti/Development/repos/ts203/bar.ts",
"diagnostics": []
}
[Trace - 10:32:21 AM] Event received: semanticDiag (0).
Data: {
"file": "/Users/chrmarti/Development/repos/ts203/bar.ts",
"diagnostics": []
}
[Trace - 10:33:42 AM] Sending request: open (3). Response expected: no. Current queue length: 0
Arguments: {
"file": "/Users/chrmarti/Development/repos/ts203/boo.ts",
"fileContent": "export function boo() {\n console.log('boo');\n}\n"
}
[Trace - 10:33:42 AM] Sending request: close (4). Response expected: no. Current queue length: 0
Arguments: {
"file": "/Users/chrmarti/Development/repos/ts203/bar.ts"
}
[Trace - 10:33:42 AM] Sending request: geterr (5). Response expected: no. Current queue length: 0
Arguments: {
"delay": 0,
"files": [
"/Users/chrmarti/Development/repos/ts203/boo.ts",
"/Users/chrmarti/Development/repos/ts203/app.ts"
]
}
[Trace - 10:33:42 AM] Event received: syntaxDiag (0).
Data: {
"file": "/Users/chrmarti/Development/repos/ts203/boo.ts",
"diagnostics": []
}
[Trace - 10:33:42 AM] Event received: semanticDiag (0).
Data: {
"file": "/Users/chrmarti/Development/repos/ts203/boo.ts",
"diagnostics": []
}
[Trace - 10:33:42 AM] Event received: syntaxDiag (0).
Data: {
"file": "/Users/chrmarti/Development/repos/ts203/app.ts",
"diagnostics": []
}
[Trace - 10:33:42 AM] Event received: semanticDiag (0).
Data: {
"file": "/Users/chrmarti/Development/repos/ts203/app.ts",
"diagnostics": [
{
"start": {
"line": 1,
"offset": 22
},
"end": {
"line": 1,
"offset": 29
},
"text": "File '/Users/chrmarti/Development/repos/ts203/bar.ts' is not a module."
}
]
}
[Trace - 10:33:43 AM] Event received: syntaxDiag (0).
Data: {
"file": "/Users/chrmarti/Development/repos/ts203/boo.ts",
"diagnostics": []
}
[Trace - 10:33:43 AM] Event received: semanticDiag (0).
Data: {
"file": "/Users/chrmarti/Development/repos/ts203/boo.ts",
"diagnostics": []
}
[Trace - 10:33:48 AM] Sending request: open (6). Response expected: no. Current queue length: 0
Arguments: {
"file": "/Users/chrmarti/Development/repos/ts203/bar.ts",
"fileContent": "export function boo() {\n console.log('boo');\n}\n"
}
[Trace - 10:33:48 AM] Sending request: close (7). Response expected: no. Current queue length: 0
Arguments: {
"file": "/Users/chrmarti/Development/repos/ts203/boo.ts"
}
[Trace - 10:33:48 AM] Sending request: geterr (8). Response expected: no. Current queue length: 0
Arguments: {
"delay": 0,
"files": [
"/Users/chrmarti/Development/repos/ts203/bar.ts",
"/Users/chrmarti/Development/repos/ts203/app.ts"
]
}
[Trace - 10:33:48 AM] Event received: syntaxDiag (0).
Data: {
"file": "/Users/chrmarti/Development/repos/ts203/bar.ts",
"diagnostics": []
}
[Trace - 10:33:48 AM] Event received: semanticDiag (0).
Data: {
"file": "/Users/chrmarti/Development/repos/ts203/bar.ts",
"diagnostics": []
}
[Trace - 10:33:48 AM] Event received: syntaxDiag (0).
Data: {
"file": "/Users/chrmarti/Development/repos/ts203/app.ts",
"diagnostics": []
}
[Trace - 10:33:48 AM] Event received: semanticDiag (0).
Data: {
"file": "/Users/chrmarti/Development/repos/ts203/app.ts",
"diagnostics": [
{
"start": {
"line": 1,
"offset": 22
},
"end": {
"line": 1,
"offset": 29
},
"text": "Cannot find module './bar'."
}
]
}
The text was updated successfully, but these errors were encountered: