-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visual indicator for extension packs in extension search results #89962
Comments
@misolori Any suggestions for visual indications? |
Here's a couple of ideas: 1. Multiple tile thumbnailWe could load the various thumbnails of the other extensions into a grid 2. Stacks viewWe can try and make the image look like a "stack" of icons so that it appears to be many 3. Number badgeWe could re-use our badge and append the total number of extensions in the pack. This could get a little busy with remote extensions since those have a remote badge in the bottom right. 4. Icon badgeThis could also get busy with the remote badge but provides an entry point into the extension pack. |
I like the number badge since it doesn't obscure the icon and clearly shows what you're getting into. I'd also like to see the extension pack prioritized in the search results with all extensions in the pack nested underneath. Something like this That way, I can see what exactly is included in the tiles and even install just a couple of what's included without grabbing the pack and uninstalling/disabling things I don't want. |
I'm definitely feeling that 👍 |
Great ideas. I like the last proposal. |
After getting feedback from the team, it appears the first option (tiles) is the favorable one since it doesn't feel too "heavy" compared to the extra row of icons. |
Deferring the implementation to next milestone. |
It would be nice to have collapsible groups of extensions in general. The extensions in a given group wouldn't have to be indented, taking more space to show. Instead, when expanded the group underneath could just share a slightly different background color and maybe an inset shadow to show the grouping. I just created a quick CodeSandbox here based on the TreeView from material-ui to demonstrate the concept. Here's a picture too: My extension list is already so cluttered, it's hard to manage. Ultimately, I'd love to see grouping based on package and/or user-defined tags but at least being able to group and collapse extension packs would be amazing! |
- add count badge in extension viewlet - show extensions in details page
Yeah there are enough number of extension packs with atleast more than 4 extensions. I do not want read me to be pushed much further down. Above is the ideal proportional size for extensions and read me. Agree that two scroll bars is not ideal but not odd :) |
I think it would be worthwhile to update the extension pack items from the mockups above:
If you do happen to get into a place where there are more extensions and you need to scroll, it can look like like there is only a certain amount and can be misleading (see below). And double scroll bars is something we intentionally avoid so we should allow the height to be dynamic. |
I am not comfortable to have dynamic height for extensions, because this will push read me to bottom. See the following screen shot - Extension pack with many extensions (ignore the overlay) My suggestion: Show scroll bar if an extension pack has more than 9 extensions. I think its a fair middle ground. |
Ok let’s try that limit to see how it goes. Would be nice to set the height so that if there are more than 9 For showing the install button, why is this useful in this case? Isn’t the point and the guidance to install the extension pack which install all the extensions? I don’t see the point of having that button visible and defeats the purpose of the extension pack. |
Good idea.
Don't want to limit and also want to give consistent representation of extension. Manage action is also available if the extension is already installed. |
Its an improvement from stable. It will make it easy for me to browse an extension pack and install the extensions I want from that pack individually. Also the same for uninstalling. |
Instead of a double scrollbar, wouldn't it make more sense to make the section expandable with a button/link at the bottom middle or left of the list of extensions that just says "Show more" or "Show all extensions" or something to that effect? That way the readme is still visible but the user can choose to expand the extension list as part of the one scrollable content area. |
Another option is to just have the list overflow horizontally and scroll left and right, instead of up and down. |
Filed #94346 for expandable/collapsible section. |
It seems we determined the expandable/collapsible section wasn't feasible. Are there other approaches? I was watching Clarkio's stream today and he ran into this issue: https://clips.twitch.tv/CharmingLivelyPrariedogRiPepperonis |
@connor4312 I hadn't noticed the comment on the other issue that was opened to track it but it seems there was a misunderstanding based on the comment and the screenshot. There shouldn't be any feasibility problem as long as the expandable area is inserted at the top of the readme in the same scrollable area instead of expanding above the scrollable area and shrinking it. |
Lets continue the discussion in #94346 |
Today, it's possible to see the extensions that are part of an extension pack, but that requires that I click on the extension then click the "extension pack" header. I'd like to know, without clicking, that an extension is an extension pack via some kind of icon in the header.
It would be nice to link directly to the extension pack details (list of extensions in the pack) if the extension pack icon is clicked.
The text was updated successfully, but these errors were encountered: