Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the dependency structure around the environment service #102928

Closed
wants to merge 2 commits into from

Conversation

inspirer
Copy link
Contributor

This PR fixes #102918

I followed the example of INativeWorkbenchEnvironmentService and extracted IBrowserWorkbenchEnvironmentService, splitting the workspace configuration options into two files: vs/workbench/{common,browser}/options.ts. Maybe I should have used the 'Web' infix instead of 'Browser' to highlight that those are web-only components, not reusable in the electron version. I'm happy to follow up and update this pull request as needed.

This PR also adds missing code-import-patterns for the web version.

Now looking at the code one again, I wonder if we should promote all common contributions relying on the common environment service's options to browser as they don't make much sense in other environments. This can be done in a separate step though. There are:

@ghost
Copy link

ghost commented Jul 20, 2020

CLA assistant check
All CLA requirements met.

@bpasero bpasero marked this pull request as draft July 20, 2020 13:24
@bpasero bpasero self-assigned this Jul 20, 2020
@bpasero bpasero added this to the Backlog milestone Jul 20, 2020
@bpasero
Copy link
Member

bpasero commented Jul 20, 2020

@inspirer are the code layer rules in ESLint something to extract from this PR if they make sense individually?

As for the rest, #102918 (comment) applies.

@inspirer
Copy link
Contributor Author

Shall I extract the eslintrc change into a separate PR? I'll have to leave out the line that forbids common/environmentService.ts to depend on workbench.web.api.ts.

@bpasero
Copy link
Member

bpasero commented Oct 3, 2020

Sorry but I am going ahead to close this, I feel I need to think about this problem myself and would not accept help in form of a PR.

@bpasero bpasero closed this Oct 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment service debt between common, browser, native
2 participants