Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TestOrbit #107

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Refactor TestOrbit #107

merged 3 commits into from
Aug 31, 2023

Conversation

moeyensj
Copy link
Owner

This PR adds a new TestOrbit class that has a function range_observations which takes a qv.Linkage[PointSourceDetections, Exposures] and will return a RangedPointSourceDetections table with rho values populated with the topocentric distance to each detection if they were to lie at the same distance from the Sun as the test orbit.

Note: this PR currently relies on the following to be merged in adam_core:

I have drafted a few unit tests and will add them.

@spenczar, if you want to take a look now as an initial design review that would be sweet.

Copy link
Collaborator

@spenczar spenczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No immediate concerns. I want a little bit of time to think about this but I like the way it is looking. The RangedPointSourceDetections table is a wonderful and simple way to handle this.

@moeyensj moeyensj force-pushed the v2.0-jm-test-orbit branch from c3fb152 to 6f7b1a9 Compare August 29, 2023 18:02
Copy link
Collaborator

@spenczar spenczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.object_id should be set to None so it isnt undefined

@spenczar spenczar mentioned this pull request Aug 30, 2023
@moeyensj moeyensj marked this pull request as ready for review August 31, 2023 05:12
@moeyensj moeyensj merged commit 99c110f into v2.0 Aug 31, 2023
@moeyensj moeyensj deleted the v2.0-jm-test-orbit branch August 31, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants