Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new TestOrbit class that has a function
range_observations
which takes aqv.Linkage[PointSourceDetections, Exposures]
and will return aRangedPointSourceDetections
table with rho values populated with the topocentric distance to each detection if they were to lie at the same distance from the Sun as the test orbit.Note: this PR currently relies on the following to be merged in adam_core:
I have drafted a few unit tests and will add them.
@spenczar, if you want to take a look now as an initial design review that would be sweet.