depends: always pass --with-pic to autoconf builds #9671
Merged
+3
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFFFC0000
reviewed
Jan 4, 2025
|
My understanding is that this flag instructs See also the libtool documentation (Note: Precision Independent Code is a security feature. Our release binaries are already PIE. |
tobtoht
force-pushed
the
depends_with_pic
branch
from
670a632 to
12487dd
Compare
selsta
approved these changes
Jan 25, 2025
0xFFFC0000
approved these changes
Jan 26, 2025
tobtoht
force-pushed
the
depends_with_pic
branch
from
12487dd to
325e317
Compare
0xFFFC0000
approved these changes
Feb 13, 2025
MrCyjaneK
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Also in full support, I had to enable pic for contrib/depends manually when building wallet_api in monero_c in order to link for iOS and android, this change remove at least a couple lines of extra patches.
While not this exact approach I have also tested the same config option
selsta
approved these changes
Feb 13, 2025
jeffro256
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.