Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Setup-firefox action for FoxPuppet #330

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

Temidayo32
Copy link
Collaborator

Because

This commit

  • Adds a local setup-firefox build that can used in our GitHub actions for FoxPuppet

Fixes #329

@Temidayo32 Temidayo32 requested a review from b4handjr January 11, 2025 14:53
@b4handjr
Copy link
Contributor

Thanks for working on this. Looks like the tests are still failing for the same reason. I think you need to point our workflow for the tests to use your custom workflow now.

@Temidayo32
Copy link
Collaborator Author

Thanks for working on this. Looks like the tests are still failing for the same reason. I think you need to point our workflow for the tests to use your custom workflow now.

Yeah, that's the next thing. But don't I need to modify our workflow in settings? which I don't have access to.

@b4handjr
Copy link
Contributor

Thanks for working on this. Looks like the tests are still failing for the same reason. I think you need to point our workflow for the tests to use your custom workflow now.

Yeah, that's the next thing. But don't I need to modify our workflow in settings? which I don't have access to.

No, you can edit the workflow here https://github.com/mozilla/FoxPuppet/blob/main/.github/workflows/linux_tests.yml

@Temidayo32
Copy link
Collaborator Author

Thanks for working on this. Looks like the tests are still failing for the same reason. I think you need to point our workflow for the tests to use your custom workflow now.

Yeah, that's the next thing. But don't I need to modify our workflow in settings? which I don't have access to.

No, you can edit the workflow here https://github.com/mozilla/FoxPuppet/blob/main/.github/workflows/linux_tests.yml

I didn't realize that. Let me do that right now

Our current setup-firefox build is causing tests to fail in CI.
While we await fixes to be pushed in the setup-firefox repo, we
can utilize a local build that includes the fix pulled from the
repo (browser-actions/setup-firefox#623)
@Temidayo32
Copy link
Collaborator Author

Great! the fix now works!

Copy link
Contributor

@b4handjr b4handjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@b4handjr b4handjr merged commit 05a6d11 into mozilla:main Jan 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roll our own setup-firefox action until the mainline version updates
2 participants