Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type(fix): Ensure GitHub Action runs the latest versions of Firefox #345

Merged
merged 3 commits into from
Feb 5, 2025
Merged

type(fix): Ensure GitHub Action runs the latest versions of Firefox #345

merged 3 commits into from
Feb 5, 2025

Conversation

Temidayo32
Copy link
Collaborator

@Temidayo32 Temidayo32 commented Feb 5, 2025 •
edited
Loading

Because

  • FoxPuppet needs to be updated to reflect new updates to the Firefox browser. This won't be possible if tests are not running again the latest versions of Firefox.
  • The is_private property defined on the BrowserWindow class is outdated.

This commit

  • Ensure FoxPuppet tests are running against the latest Firefox versions.
  • Updates the is_private method to use Private Window ESM module. This is done using dynamic imports.

Fixes #344, #346

@Temidayo32 Temidayo32 requested a review from b4handjr February 5, 2025 14:51
b4handjr
b4handjr reviewed Feb 5, 2025
View reviewed changes
foxpuppet/windows/browser/bookmarks/bookmark.py
@@ -197,7 +201,7 @@ class BookmarkLocators:
MANAGE_BOOKMARKS = (By.ID, "bookmarksShowAll")
MENU_BAR = (By.ID, "toggle_toolbar-menubar")
NAME_FIELD = (By.ID, "editBMPanel_namePicker")
NAVIGATOR_TOOLBOX = (By.ID, "navigator-toolbox")
NAVIGATOR_TOOLBOX = (By.ID, "TabsToolbar")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like the right one!

b4handjr
b4handjr approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@b4handjr b4handjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for getting this fixed!

@b4handjr b4handjr merged commit 183ce1a into mozilla:main Feb 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b4handjr b4handjr b4handjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure Firefox Nightly Updates to the latest in GitHub Actions Workflow
2 participants
@Temidayo32 @b4handjr