[PoC] misc/io_utils.rs: add rust impl of atomic file save #15934
+260
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much to say, just Rust. It turns out to be relatively simple to integrate. Dependencies need to be manually added as subprojects. I specifically tested this on file IO with external
tempfile
crate and its dependencies.This is PoC of visibility of Rust in mpv and of course will not happen for such small functionality, but if there would be good reason to use it, why not? Maybe it will bring some new contributors.
I know some people will get really mad at this PR :^)
(don't judge my rust code, I only wanted to try how it integrates in mpv)
EDIT:
I wanted a trial by fire and use heavy file io and fs functions. Works well on Windows and Linux with hardcoded flags for rustix, but to support also macos build, it needs more magic in meson. Though this is good exercise to know what are the challenges. More standalone examples works fine. We obviously are not merging this, it's more of a research of feasibility.