Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow owner to disable guest links #543

Open
mtlynch opened this issue Feb 7, 2024 · 4 comments
Open

Allow owner to disable guest links #543

mtlynch opened this issue Feb 7, 2024 · 4 comments
Assignees
@x1uc

Comments

@mtlynch
Copy link
Owner

mtlynch commented Feb 7, 2024

I just ran into a situation where I accidentally published a guest link too widely. I wanted to expire it and add a note explaining why it was disabled, but my only option was to delete it.
@mtlynch mtlynch changed the title Allow owner to disabled guest links Allow owner to disable guest links Feb 10, 2024
@kovmir
Copy link

kovmir commented Mar 27, 2024

I wanted to expire it and add a note explaining why it was disabled

Does that mean you want the ability to re-enable that same link later?

@Liebeg
Copy link

Liebeg commented Apr 28, 2024

beeing able to enable and disable links with a switch would be a quite greate feature

@x1uc
Copy link
Contributor

x1uc commented Jan 2, 2025 •
edited
Loading

@mtlynch I'm interested in working on this issue. Can I be assigned to it?🤩

@mtlynch
Copy link
Owner Author

mtlynch commented Jan 2, 2025

@x1uc - Sure, that would be great!

@x1uc x1uc mentioned this issue Jan 4, 2025
Merged
mtlynch added a commit that referenced this issue Jan 11, 2025
@x1uc @mtlynch
feat: Allow owner to disable guest links (#646)
2e8c05f 
**feat:** Allow owner to disable guest links

This PR implements the feature request in
[#543](#543).

To summarize what has been done:

- Added a column (`disabled`) to the `guest_links` table & the
`GuestLink` struct.
- Updated the `isActive` check for guest links to include the `disabled`
field.
- Added a column on the guest links front page, with a button to
enable/disable the link.
- Added new APIs related to managing guest links' disabled state.

I’m a beginner, and I believe there may be many areas where my work
lacks standardization from your perspective. Please point them out, and
I will work on improving. I’m very glad to hear your suggestions, which
will not only improve the quality of this project but also enhance my
programming skills.

----
Screen

![output](https://github.com/user-attachments/assets/92278f4e-f4a6-4105-9058-c4b4b458dfbe)

---------

Co-authored-by: Michael Lynch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@x1uc x1uc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mtlynch @kovmir @Liebeg @x1uc