Allow editing profile Links/Pages in list #295
Labels
good first issue
Good for newcomers
Milestone
Comments
erlend-sh
changed the title
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 4, 2025
Partially fixes .#295, allowing Page links to be edited and reordered on the Profile edit page. https://github.com/user-attachments/assets/8b244070-66b8-4734-98f9-8032ba7bbb7c There's some callouts in the code comments I'm adding here for visibility: - Sorting here is also affected by the bug the #300 fixes, but works correctly if that is also merged. - rodrigodagostino/svelte-sortable-list#11. This was fixed in svelte-sortable-list v0.10.11. I didn't want to edit package.json without explaining why first. - The last empty element can get dragged into the list (and then erased). There isn't a way to lock it while leaving it editable. Opened an issue for it here (rodrigodagostino/svelte-sortable-list#15) - Tab order for sortable covers the individual inputs. Not sure how to best to accessibly deal with this. - Copied and edited some $effects from SocialLinksEditor.svelte to keep an empty input on the list. Might be worth abstracting and merging if the same thing is needed in more places. - Links get auto removed when the url is empty without checking the label. I don't know which would make more sense / how likely someone is to delete an entire url when they plan to reuse it's label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now when we have links in the profile list, there isn't a way to edit the Label / URL after adding it.
Right now you have to remove the link and add a new one.
We want to update it so that you can click on the link (or page) and it will allow you to edit the URL / label of the link that you clicked on, instead of it opening the link in a new tab.
Bonus: We also want the ability to reorder Pages, just like links.
The text was updated successfully, but these errors were encountered: