Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked plots should allow sub object selection #1609

Closed
charlesh88 opened this issue Jun 6, 2017 · 7 comments · Fixed by #5198
Closed

Stacked plots should allow sub object selection #1609

charlesh88 opened this issue Jun 6, 2017 · 7 comments · Fixed by #5198

Comments

@charlesh88
Copy link
Contributor

Follow on to #1590 and the "new plots" work from @larkin in May 2017: we need to give the configuration options that were brought to overlay plots to stacked plots as well. Design is here, starting on page 92.

@larkin
Copy link
Contributor

larkin commented Mar 2, 2018

Retitling this to track intent: Stacked plots should

a) support sub object selection.
b) auto-create overlay plots when drag-dropping telemetry points.

@larkin larkin changed the title [Plots] Apply plot options config to stacked plots Stacked plots should allow sub object selection Mar 3, 2018
@mudinthewater
Copy link

Stacked plots should also include the frame/title (if it exists) around an overlay plot if one is dragged on. Right now it just pulls the tlm points. Either that or a handy way of entering text would work - I just want to stack a bunch of overlays and label them all nicely.

@shefalijoshi shefalijoshi self-assigned this Feb 18, 2022
@shefalijoshi
Copy link
Contributor

@charlesh88 What should the behavior be for Overlay Plots that are added to stacked plots? Should it not be listed in the series?

@charlesh88
Copy link
Contributor Author

charlesh88 commented Mar 25, 2022

@shefalijoshi per our discussion today 3/25/22:

  • We're going to leverage a sub-object editing approach in Stacked Plots (SP). The user will click on each child element in the stack in the main view to select it; once selected, that element takes over the context in the Inspector.

    • Telemetry end points should allow all the settings currently available to Series members in Overlay Plots (OP) in addition to Y axis properties:
      image

    • Overlay Plots (OP) selected while editing an SP will display their Inspectors as if in the main view, with the exception of the Legend section, which will be hidden. Any pre-existing legend settings in the OP need to be overridden by the SP's settings.
      image

  • To edit the properties for the SP, the user will have to de-select any selected child plot to "climb up" to the context of the containing SP. We should allow a click on the main view header to accomplish this, and we should consider a clickable breadcrumb element that displays as a global element while editing in the Inspector. @charlesh88 to add this as a separate enhancement request.

  • Stacked Plots should allow the same legend configuration as found in Overlay Plots:
    image

  • Styling for both types of children should be the same as available while sub-object editing in a Display Layout, including Conditional Styling.

    • Telemetry end points in an SP will be styleable, but the applied styles will only pertain to that element when viewed in that SP, consistent with our approach elsewhere.
    • Overlay Plot styling from within an SP will behave the same as if in a layout, with styles set while editing an OP in an SP being persisted with the main OP object.

@shefalijoshi
Copy link
Contributor

Testing Notes:

  • Create an Overlay Plot, add telemetry to it
  • Create a Stacked Plot
  • Add the Overlay Plot to the Stacked Plot
  • Drag another telemetry endpoint (not overlay) to the Stacked Plot and save it.

Ensure that all the rules specified in this comment work: #1609 (comment)

@charlesh88
Copy link
Contributor Author

Verified fixed Testathon 6-9-22.

@michaelrogers
Copy link
Contributor

Verified fixed in testathon 06/09/22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants