Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object API changes for Transactions needs test specs #4460

Closed
akhenry opened this issue Nov 15, 2021 · 0 comments
Closed

Object API changes for Transactions needs test specs #4460

akhenry opened this issue Nov 15, 2021 · 0 comments
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target: 1.8.2

Comments

@akhenry
Copy link
Contributor

akhenry commented Nov 15, 2021

Summary

As per our contributing guide, all code submissions require adequate automated tests. Recent changes to the object API to apply transactions do not have adequate test coverage.
@akhenry akhenry mentioned this issue Nov 15, 2021
Merged
8 tasks
@unlikelyzero unlikelyzero added this to the Target: 1.8.1 milestone Nov 15, 2021
nikhilmandlik added a commit that referenced this issue Dec 1, 2021
@nikhilmandlik
https://github.com/nasa/openmct/issues/4369
b0e9024 
#4460
@nikhilmandlik nikhilmandlik mentioned this issue Dec 1, 2021
Merged
8 tasks
nikhilmandlik added a commit that referenced this issue Dec 1, 2021
@nikhilmandlik
https://github.com/nasa/openmct/issues/4369
a3f15a4 
#4460
nikhilmandlik added a commit that referenced this issue Dec 1, 2021
@nikhilmandlik
https://github.com/nasa/openmct/issues/4369
641bc2f 
#4460
@akhenry akhenry closed this as completed Dec 13, 2021
@unlikelyzero unlikelyzero added type:maintenance tests, chores, or project maintenance and removed type:bug severity:blocker labels May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target: 1.8.2
Development

No branches or pull requests
3 participants
@nikhilmandlik @akhenry @unlikelyzero