Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] Add firefox and chrome beta to the full suite #5366

Closed
3 tasks done
unlikelyzero opened this issue Jun 16, 2022 · 2 comments · Fixed by #5328
Closed
3 tasks done

[e2e] Add firefox and chrome beta to the full suite #5366

unlikelyzero opened this issue Jun 16, 2022 · 2 comments · Fixed by #5328
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target:2.0.6

Comments

@unlikelyzero
Copy link
Contributor

unlikelyzero commented Jun 16, 2022 •
edited
Loading

Summary

There have been a few firefox specific bugs and at least one chrome-version-specific bug in the recent past. Playwright supports running in many different browsers and in most cases, firefox support should be "free".

Execution

  • Add firefox project to playwright configs
  • Run through the current suite to see what all needs to be modified for firefox support
  • Report firefox bugs
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Jun 16, 2022
@unlikelyzero unlikelyzero mentioned this issue Jun 21, 2022
Merged
15 tasks
@unlikelyzero unlikelyzero linked a pull request Jun 30, 2022 that will close this issue
e2e Code Coverage and all test fixes #5328
Merged
15 tasks
@unlikelyzero unlikelyzero mentioned this issue Jun 30, 2022
Merged
15 tasks
@unlikelyzero unlikelyzero mentioned this issue Jul 6, 2022
Closed
3 tasks
@unlikelyzero
Copy link
Contributor Author

Testing Notes

Run the CI tests in firefox headed mode
Scan the test suite for a test which is skipping firefox execution. Run that suite with Chrome. Run that suite with firefox and verify that firefox is skipped

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Jul 8, 2022 •
edited
Loading

Reopening - this works on Circle CI but not on local machines.

@shefalijoshi shefalijoshi reopened this Jul 8, 2022
@unlikelyzero unlikelyzero mentioned this issue Jul 11, 2022
Merged
15 tasks
@unlikelyzero unlikelyzero changed the title [e2e] Add firefox and chrome canary to the full suite [e2e] Add firefox and chrome beta to the full suite Jul 15, 2022
@unlikelyzero unlikelyzero added this to the Target:2.0.6 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target:2.0.6
Development

Successfully merging a pull request may close this issue.

e2e Code Coverage and all test fixes nasa/openmct
3 participants
@shefalijoshi @ozyx @unlikelyzero