Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unit Tests] Remove firefox support now that deterministic installs and coverage is provided by playwright #5436

Closed
3 tasks
unlikelyzero opened this issue Jul 6, 2022 · 0 comments · Fixed by #5537
Closed
3 tasks

[Unit Tests] Remove firefox support now that deterministic installs and coverage is provided by playwright #5436

unlikelyzero opened this issue Jul 6, 2022 · 0 comments · Fixed by #5537
Labels
type:maintenance tests, chores, or project maintenance

Comments

@unlikelyzero
Copy link
Contributor

Summary

Now that #5366 has merged, we have coverage for firefox in our testing matrix. We ignored firefox support in the unit test framework for 6 months: #4719.

We should consider removing firefox support from the unit testing framework until the need arises.

  • Remove firefox from karma configuration
  • Remove firefox from npm scripts
  • Remove firefox from circleci nightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[e2e] Refactor and document our extension of existing Playwright API and RFE features nasa/openmct
1 participant
@unlikelyzero