Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Persistence tests #4943

Merged
merged 15 commits into from
Mar 17, 2022
Merged

[e2e] Persistence tests #4943

merged 15 commits into from
Mar 17, 2022

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Mar 16, 2022

Closes #4940

Describe your changes:

Adds one working test and related fixme stubs

based off of this comment, @unlikelyzero will write the following:

Duplicate Form Actions
Move Form Actions
Link Form Actions
Remove Form Actions

Cannot Select Items without Composition in the Location Field
i.e. Cannot Set Telemetry Point as Destination. Anything without Composition Provider

ExportAsJSON Form Actions
ImportAsJSON Form Actions

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@jvigliotta jvigliotta requested a review from unlikelyzero March 16, 2022 16:04
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #4943 (7b9db65) into master (93a81a1) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4943      +/-   ##
==========================================
- Coverage   50.49%   50.49%   -0.01%     
==========================================
  Files         497      497              
  Lines       18401    18401              
  Branches     1657     1657              
==========================================
- Hits         9292     9291       -1     
  Misses       8694     8694              
- Partials      415      416       +1     
Impacted Files Coverage Δ
src/plugins/imagery/components/ImageryTimeView.vue 71.83% <0.00%> (-0.58%) ⬇️
src/ui/components/ObjectView.vue 44.08% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a81a1...7b9db65. Read the comment docs.

@jvigliotta jvigliotta changed the title initial setup for createButton e2e test [e2e] Persistence tests Mar 16, 2022
// Right click on a non persistable item in the tree
// verify that the only actions available are: "Open in a new Tab", "View" and "Create Link"
});
test.only('Cannot move a previously created domain object to non-peristable boject in Move Modal', async ({ page }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just stub this out with a test.fixme()

@jvigliotta jvigliotta reopened this Mar 17, 2022
@jvigliotta jvigliotta added pr:e2e Automatically triggers e2e tests to run pr:visual labels Mar 17, 2022
@jvigliotta jvigliotta marked this pull request as ready for review March 17, 2022 21:17
@github-actions
Copy link

Started e2e Run. Follow along: https://github.com/nasa/openmct/actions/runs/2000917276

1 similar comment
@github-actions
Copy link

Started e2e Run. Follow along: https://github.com/nasa/openmct/actions/runs/2000917276

@github-actions
Copy link

Success ✅ ! Build artifacts are here: https://github.com/nasa/openmct/actions/runs/2000917276

@jvigliotta jvigliotta requested a review from unlikelyzero March 17, 2022 21:25
@github-actions
Copy link

Success ✅ ! Build artifacts are here: https://github.com/nasa/openmct/actions/runs/2000917276

Copy link
Contributor

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unlikelyzero unlikelyzero merged commit 492ff2f into master Mar 17, 2022
@unlikelyzero unlikelyzero deleted the persistence-e2e-tests branch March 17, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e Automatically triggers e2e tests to run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] Add coverage for 4323
3 participants