Fix existing eslint warnings, configure eslint to fail on warning #5258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolves `vue/require-default-prop` warning
- Disable the rule for now as the implementation they suggest doesn't match lodash `_.get()` functionality, and fails a bunch of our tests. See you-dont-need/You-Dont-Need-Lodash-Underscore#311 and you-dont-need/You-Dont-Need-Lodash-Underscore#294
Codecov Report
@@ Coverage Diff @@
## master #5258 +/- ##
==========================================
- Coverage 50.21% 49.97% -0.24%
==========================================
Files 548 548
Lines 20127 20127
Branches 1864 1864
==========================================
- Hits 10106 10058 -48
- Misses 9539 9588 +49
+ Partials 482 481 -1
Continue to review full report at Codecov.
|
unlikelyzero
suggested changes
May 25, 2022
| @@ -82,7 +82,7 @@ | |||
| "clean": "rm -rf ./dist ./node_modules ./package-lock.json", | |||
| "clean-test-lint": "npm run clean; npm install; npm run test; npm run lint", | |||
| "start": "node app.js", | |||
| "lint": "eslint example src e2e --ext .js,.vue openmct.js", | |||
| "lint": "eslint example src e2e --ext .js,.vue openmct.js --max-warnings=0", | |||
- Add exception and FIXME for timeout - Add comment on fixme test to discourage community contribution
- remove unnecessary awaits - update locators to use data-testid where possible - remove unnecessary wait
| // FIXME: This defaults to 5000 ms in execution, but there's a bug | ||
| // which causes the historical images to not populate for certain delay values. | ||
| // Update the value to 5000 ms when the bug is fixed. | ||
| // See: https://github.com/nasa/openmct/issues/5265 |
There was a problem hiding this comment.
I would maybe add the testannotation for this github issue so that we can track it in the test reporting
| await page.waitForTimeout(21); | ||
| let imageCount = await page.locator('.c-imagery__thumb').count(); | ||
| try { | ||
| // Wait for at least one new image to stream in |
There was a problem hiding this comment.
We could also consider polling until true here https://playwright.dev/docs/test-assertions#polling
There was a problem hiding this comment.
Yes!! This is what I was looking for. Awesome.
unlikelyzero
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5231
Describe your changes:
Resolve all existing eslint warnings, and configure lint step to fail if it encounters > 0 warnings.
All Submissions:
Author Checklist
Reviewer Checklist