Upgrade to karma-jasmine 5.1.0 and fix unit tests
#5503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5503 +/- ##
==========================================
+ Coverage 53.25% 53.46% +0.21%
==========================================
Files 594 594
Lines 22684 22684
Branches 2049 2049
==========================================
+ Hits 12080 12128 +48
+ Misses 10028 9980 -48
Partials 576 576
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: unlikelyzero <[email protected]>
* Installed gauge plugin by default * Make gauge part of standard install in e2e suite and add restrictednotebook Co-authored-by: Andrew Henry <[email protected]>
Co-authored-by: Andrew Henry <[email protected]> Co-authored-by: Shefali Joshi <[email protected]>
* Rename stacked plot interceptor and move to folder Co-authored-by: Andrew Henry <[email protected]>
* Fix timer test * be explicit about the warnings text * add full suite to CI to enable CircleCI Checks * add back in devtool=false for CI env so firefox tests run * add framework suite * Don't install webpack HMR in CI * Fix playwright version installs * exclude HMR if running tests in any environment - use NODE_ENV=TEST to exclude webpack HMR - deparameterize some of the playwright configs * use lower-case 'test' * timer hover fix * conditionally skip for firefox due to missing console events * increase timeouts to give time for mutation * no need to close save banner * remove devtool setting * revert * update snapshots * disable video to save some resources * use one worker * more timeouts :) * Remove `browser.close()` and `page.close()` as it was breaking other tests * Remove unnecessary awaits and fix func call syntax * Fix image reset test * fix restrictedNotebook tests * revert playwright-ci.config settings * increase timeout for polling imagery test * remove unnecessary waits * disable notebook lock test for chrome-beta as its unreliable - remove some unnecessary 'wait for save banner' logic - remove unused await - mark imagery test as slow in chrome-beta * LINT!! *shakes fist* * don't run full e2e suite per commit * disable video in all configs * add flakey zoom comment * exclude webpack HMR in non-development modes Co-authored-by: Jesse Mazzella <[email protected]> Co-authored-by: Jesse Mazzella <[email protected]>
ozyx
force-pushed
the
mct5405-update-unit-tests
branch
from
7fc7a24 to
ef49a6e
Compare
|
@unlikelyzero ...alright. pretty sure I rebased this correctly. |
unlikelyzero
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5405
Describe your changes:
Upgrade
karma-jasmineversion to 5.1.0 and update unit tests to be compatible.All Submissions:
Author Checklist
Reviewer Checklist