[Timelist] Fixed Time use Now as start time - 5772 #6497
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6497 +/- ##
==========================================
+ Coverage 53.72% 53.81% +0.09%
==========================================
Files 631 628 -3
Lines 25116 25025 -91
Branches 2516 2512 -4
==========================================
- Hits 13493 13468 -25
+ Misses 10951 10883 -68
- Partials 672 674 +2
*This pull request uses carry forward flags. Click here to find out more.
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
@michaelrogers This doesn't appear to be working if I change the fixed timespan bounds. Can you test this? |
@shefalijoshi - both requested changes have been made! |
IncorrectListWithLocalClock.mov |
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/14/2023 08:19:18pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 62a163d Started: 07/14/2023 08:14:04pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1 • Initial Attempt |
10.64% (5)5 / 47 runsfailed over last 7 days |
68.09% (32)32 / 47 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 133 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 07/14/2023 08:19:18pm UTC)
⚠️ Flakes
📄 functional/plugins/flexibleLayout/flexibleLayout.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Flexible Layout items in a flexible layout can be removed with object tree context menu when viewing another item
Retry 1 • Initial Attempt |
0% (0)0 / 183 runsfailed over last 7 days |
1.64% (3)3 / 183 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 2 • Retry 1 • Initial Attempt |
0.58% (1)1 / 171 runfailed over last 7 days |
78.95% (135)135 / 171 runsflaked over last 7 days |
|
I tested this again. It looks like currently active activities are not showing up in the local clock mode. Expected: |
|
After conferring with @shefalijoshi - the ticket will be updated to hide activities outside the time bounds. |
|
@shefalijoshi - I've updated the filter function to only include activities that fall within the bounds. Note: this affects both fixed and realtime modes of the clock. This change causes a few tests to fail, but I wanted to confirm that the bounds based filtering is what we are after before proceeding to update the tests. |
There was a problem hiding this comment.
Changes are looking good. I do think that we should make sure we include current activities (see comment).
I've also created a followup issue to replace the time controls in the inspector with the independent time conductor. Let's implement that immediately after this is merged.
…lized logic to method
|
@shefalijoshi To take a look at failing tests |
|
Changes look good to me. I've filed a followup issue to use the new global clock in fixed mode. |
…ew code will drop activities outside time bounds and default bounds are 0,1
Closes #5772
Describe your changes:
Updated the fixed time timelist to show current / future events based on the current time. Edit mode view all flag is still maintained. Start / end time formatter updated to use the Time API formatter instead of moment directly.
All Submissions:
Author Checklist
Reviewer Checklist