-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProgressBar null not undefined #6953
Conversation
Current Playwright Test Results Summary✅ 136 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/29/2023 11:20:39pm UTC)
|
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
3.08% (2)2 / 65 runsfailed over last 7 days |
50.77% (33)33 / 65 runsflaked over last 7 days |
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 63 runsfailed over last 7 days |
46.03% (29)29 / 63 runsflaked over last 7 days |
📄 functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1 • Initial Attempt |
3.13% (2)2 / 64 runsfailed over last 7 days |
12.50% (8)8 / 64 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0% (0)0 / 96 runsfailed over last 7 days |
52.08% (50)50 / 96 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6953 +/- ##
==========================================
+ Coverage 48.30% 48.31% +0.01%
==========================================
Files 643 643
Lines 25730 25730
Branches 2512 2512
==========================================
+ Hits 12429 12432 +3
+ Misses 12819 12817 -2
+ Partials 482 481 -1
*This pull request uses carry forward flags. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Closes #6085
Describe your changes:
Change parameter from undefined to null
All Submissions:
Author Checklist
Reviewer Checklist