Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): note sections #6997

Merged
merged 5 commits into from
Aug 28, 2023
Merged

fix(readme): note sections #6997

merged 5 commits into from
Aug 28, 2023

Conversation

evenstensberg
Copy link
Contributor

@evenstensberg evenstensberg commented Aug 26, 2023

Describe your changes:

Prettifies the readme a bit

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Aug 26, 2023

Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/28/2023 07:49:41pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: b941d1e

Started: 08/28/2023 07:42:37pm UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
1.52% (1) 1 / 66 run
failed over last 7 days
33.33% (22) 22 / 66 runs
flaked over last 7 days

📄   functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1Initial Attempt
3.13% (2) 2 / 64 runs
failed over last 7 days
18.75% (12) 12 / 64 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 95 runs
failed over last 7 days
52.63% (50) 50 / 95 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #6997 (bc5d7b1) into master (a8678aa) will increase coverage by 10.40%.
The diff coverage is n/a.

❗ Current head bc5d7b1 differs from pull request most recent head b941d1e. Consider uploading reports for the commit b941d1e to get more accurate results

@@             Coverage Diff             @@
##           master    #6997       +/-   ##
===========================================
+ Coverage   46.87%   57.27%   +10.40%     
===========================================
  Files         643      410      -233     
  Lines       25730    12701    -13029     
  Branches     2512        0     -2512     
===========================================
- Hits        12061     7275     -4786     
+ Misses      13188     5426     -7762     
+ Partials      481        0      -481     
Flag Coverage Δ *Carryforward flag
e2e-full 42.00% <ø> (-0.04%) ⬇️ Carriedforward from e9b6c05
e2e-stable 54.31% <ø> (+0.94%) ⬆️
unit ?

*This pull request uses carry forward flags. Click here to find out more.

see 428 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8678aa...b941d1e. Read the comment docs.

@ozyx ozyx added the source:community Community contribution or request label Aug 28, 2023
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome. Thanks for this!

@ozyx ozyx enabled auto-merge (squash) August 28, 2023 19:44
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 28, 2023
@ozyx ozyx merged commit cbac2c1 into nasa:master Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb source:community Community contribution or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants