Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons not visible in dark theme #1042

Closed
unix0r opened this issue Jan 3, 2019 · 3 comments
Closed

Buttons not visible in dark theme #1042

unix0r opened this issue Jan 3, 2019 · 3 comments
Assignees
@tcitworld
Labels
1. to develop Accepted and waiting to be taken care of bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@unix0r
Copy link

unix0r commented Jan 3, 2019 •
edited
Loading

Hey guys,
just activated the new dark theme in nextcloud 15 and two buttons are not visible due to too dark color:

bildschirmfoto von 2019-01-03 08-02-59

The Datepickers (left and right of Januar 2019) for changing the month are still black.

Maybe set them to the same color as the month string?
Edit:
leftarrow.svg and rightarrow.svg are the icons.

Calendar Version: 1.6.4
Nextcloud Version: 15.0.0.10
@tcitworld tcitworld self-assigned this Jan 3, 2019
@tcitworld tcitworld added 1. to develop Accepted and waiting to be taken care of bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels Jan 3, 2019
@tcitworld
Copy link
Member

Confirmed and missed it in #941

tcitworld added a commit that referenced this issue Jan 3, 2019
@tcitworld
Fix dark mode arrows
a772279 
Replaces custom arrows with core ones, allowing them to be themed. Use
flex to properly align buttons

Closes #1042

Signed-off-by: Thomas Citharel <[email protected]>
@tcitworld tcitworld mentioned this issue Jan 3, 2019
Merged
@0x4647
Copy link

0x4647 commented Jan 11, 2019

Hi Artur,
I can confirm this also in my white theme.
Can you please check in the browser console if you get a 404 for the leftarrow.svg and rightarrow.svg?
I think the files are missing in the Calendar app completely ^^

Best regards.

@georgehrke
Copy link
Member

@0x4647 That seems to be in issue in your particular instance. If you look at @unix0r's screenshot you can actually see the arrows, but they are simply black on a dark grey background.

@tcitworld tcitworld mentioned this issue Apr 4, 2019
Merged
georgehrke pushed a commit that referenced this issue Apr 4, 2019
@tcitworld @georgehrke
Fix dark mode arrows
465e121 
Replaces custom arrows with core ones, allowing them to be themed. Use
flex to properly align buttons

Closes #1042

Signed-off-by: Thomas Citharel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcitworld tcitworld

Labels
1. to develop Accepted and waiting to be taken care of bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@georgehrke @tcitworld @unix0r @0x4647