Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back event-limit #1800

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Bring back event-limit #1800

merged 1 commit into from
Jan 13, 2020

Conversation

georgehrke
Copy link
Member

Before:
C9D74638-E04E-4A5D-A5FD-520CE1E8E528

After:
6776DB03-D99F-4FA3-9B7B-A78AFD757A50

Prevents one week from taking over the entire month view.

Signed-off-by: Georg Ehrke <[email protected]>
@georgehrke georgehrke added the 3. to review Waiting for reviews label Jan 13, 2020
@georgehrke georgehrke added this to the 2.0.0 beta4 milestone Jan 13, 2020
@tcitworld
Copy link
Member

How is it looking on DayView?

For the all-day section in the TimeGrid views, a value of true will limit the number of events to 5.

https://fullcalendar.io/docs/eventLimit

@georgehrke
Copy link
Member Author

image

Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for me.
Ping @jancborchardt for dayView if it needs changes

@georgehrke
Copy link
Member Author

georgehrke commented Jan 13, 2020

Ping @jancborchardt for dayView if it needs changes

He says yes. (Yes, as in looks good)

@georgehrke georgehrke merged commit 454ecb8 into master Jan 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/noid/event-limit branch January 13, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants