move some calendarService calls into Calendar and subscription model #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tcitworld, @tomneedham and @raghunayyar to be potential reviewers. |
georgehrke
force-pushed
the
feature/noid/calendarservice_in_calendar_and_subscription
branch
from
bd23022 to
1b14243
Compare
georgehrke
commented
Nov 30, 2016
| @@ -415,11 +419,20 @@ app.service('CalendarService', function(DavClient, StringUtility, XMLUtility, Ca | |||
| }; | |||
|
|
|||
| /** | |||
| * get properties for a calendar without instantiate a new calendar/webcal object | |||
There was a problem hiding this comment.
typo -> instantiating
georgehrke
commented
Nov 30, 2016
| @@ -285,27 +285,29 @@ app.service('CalendarFactory', function($window, DavClient, Calendar, WebCal) { | |||
|
|
|||
| /** | |||
| * get a calendar object from raw xml data | |||
| * @param {CalendarService} CalendarService | |||
There was a problem hiding this comment.
this is not the CalendarService, but its private API
add proper jsdoc
georgehrke
force-pushed
the
feature/noid/calendarservice_in_calendar_and_subscription
branch
from
1b14243 to
6c7fb2f
Compare
georgehrke
force-pushed
the
feature/noid/calendarservice_in_calendar_and_subscription
branch
from
6c7fb2f to
3179f20
Compare
|
please review @tcitworld |
georgehrke
added
3. to review
This was referenced Dec 5, 2016
Closed
|
Will give a try this afternoon. |
|
👍 |
georgehrke
deleted the
feature/noid/calendarservice_in_calendar_and_subscription
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move
update,delete,share,unshare,publishandunpublishstraight into the calendar respectively the webcal object to use these functions without having the CalendarService as dependency everywherethis will come very handy at implementing: