EnvelopeSkeleton: add filler on hover to prevent text shifting #10583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GVodyanov
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
GretaD
reviewed
Feb 4, 2025
| @@ -633,6 +637,15 @@ export default { | |||
| justify-content: center; | |||
| align-self: start; | |||
| margin-top: 0; | |||
| display: flex; | |||
| flex-direction: column-reverse; | |||
| align-items: flex-end; | |||
There was a problem hiding this comment.
these will not be applied because the parent is display none. It still jumps for me
There was a problem hiding this comment.
@GretaD The parent is display none only when not hovered, the idea here is that:
- Before hover the date occupies space
- After hover the actions occupy space, but less than the date
To fix this I added the filler only when actions are present, it takes up the same space that the date would have taken up. I just noticed however that there was a 1px difference and fixed it, could you please test again?
Signed-off-by: Grigory Vodyanov <[email protected]>
GVodyanov
force-pushed
the
style/fix-envelope-text-shifting
branch
from
c247975 to
11d126c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 1/2 #10561
When hovering on envelopes in the envelope list, the preview text shouldn't expand when date is hidden