Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Only show hours and minutes in first login timestamp #50305

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jan 21, 2025

Summary

Before After
image image

Checklist

@Pytal Pytal added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: users and groups labels Jan 21, 2025
@Pytal Pytal added this to the Nextcloud 31 milestone Jan 21, 2025
@Pytal Pytal requested review from marcoambrosini and a team January 21, 2025 22:03
@Pytal Pytal self-assigned this Jan 21, 2025
@Pytal Pytal requested review from nfebe, szaimen and sorbaugh and removed request for a team January 21, 2025 22:03
@Pytal
Copy link
Member Author

Pytal commented Jan 21, 2025

/compile

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the screenshot :)

Signed-off-by: nextcloud-command <[email protected]>
relativeTime: false,
format: {
timeStyle: 'short',
dateStyle: 'short',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the date style as short looks a bit weird in German, but thats fine if space is a problem.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pytal Pytal merged commit 5e355c0 into master Jan 21, 2025
120 checks passed
@Pytal Pytal deleted the chore/first-login-hours-minutes branch January 21, 2025 23:13
@Altahrim Altahrim mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. feature: users and groups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants