Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable31] fix(settings): Clarify peculiarities of enabling encryption #50594

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 31, 2025

Backport of #50424

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from artonge, szaimen and susnux January 31, 2025 16:18
@backportbot backportbot bot added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: encryption (server-side) labels Jan 31, 2025
@backportbot backportbot bot added this to the Nextcloud 31 milestone Jan 31, 2025
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

- Clarify that enabling server side encryption will not encrypt
  existing files but only new or changed files.
- Clarify that server side encryption can only be disabled using OCC
- Ensure there is accessible information of encryption state (`disabled`
  input will not be announced so make it `aria-disabled` instead)
- Make warning more prominent by moving it into a dialog

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux marked this pull request as ready for review January 31, 2025 16:22
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the backport/50424/stable31 branch from 90693ff to d3b826c Compare January 31, 2025 16:22
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 31, 2025
@sorbaugh sorbaugh merged commit 210b293 into stable31 Feb 3, 2025
117 of 118 checks passed
@sorbaugh sorbaugh deleted the backport/50424/stable31 branch February 3, 2025 10:55
@Altahrim Altahrim mentioned this pull request Feb 5, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: encryption (server-side)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants