-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added VIRTUAL_ALLOW to limit access to container #36
Comments
The added code to the server section in nginx.tmpl:
|
implementation from nginx-proxy#36
I believe this can be closed since #106 was merged. See the README for instructions: https://github.com/jwilder/nginx-proxy/blob/master/README.md#custom-nginx-configuration |
Hi, even if #106 lets us do the equivalent of this PR, I think this PR is a better solution when you want to handle all the configuration from the proxyfied container with environment variables. What do you think about keeping #106 to handle every cases, and use this PR as an additional method ? |
👍 |
👍 |
Perhaps labels are an option too; e.g. |
@thaJeztah Thanks for the reminder about labels. I haven't gotten around to playing with them yet, unfortunately. Looks like label support was added to |
This is relevant too: nginx-proxy/docker-gen#81 |
I did a change to nginx.tmpl to provide a VIRTUAL_ALLOW environment variable to limit access to containers. Adding -e VIRTUAL_ALLOW=10.1.1.0/24,10.1.3.55 will result in:
allow 10.1.1.0/24;
allow 10.1.3.55;
deny all;
The text was updated successfully, but these errors were encountered: