fix!: resolve issue with relative paths during linking #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
reviewed
Feb 17, 2025
There was a problem hiding this comment.
LGTM.
Searching through usages on library_dirs: https://github.com/search?type=code&q=library_dirs+path%253A*.gyp. It seems to me there are relative paths in library_dirs in the wild that will be break by this change. I think this PR should be released as a breaking change.
legendecas
changed the title
|
Would you mind updating the list in the document https://github.com/nodejs/gyp-next/blob/main/docs/InputFormatReference.md#pathname-relativization as well?
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodejs/node-gyp#3128