This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Windows/msi: Fix msi build issue with WiX 3.7/3.8 #4896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
pushed a commit
that referenced
this pull request
Mar 8, 2013
The `heat` tool that gathers NPM source files wasn't getting called. Closes #4896
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No one is assigned
Fix the msi build with Wix 3.7/3.8 where I ran into the following error:
C:\Users\Raymond Feng\Projects\thirdparty\node\tools\msvs\msi\product.wxs(139):
error LGHT0094: Unresolved reference to symbol 'WixComponentGroup:Product.Gene
rated' in section 'Product:*'. [C:\Users\Raymond Feng\Projects\thirdparty\node
tools\msvs\msi\nodemsi.wixproj]
The fix was based on:
http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/How-to-get-heat-exe-to-harvest-td7473250.html
I have signed CLA under name "Zhaohui Feng (aka Raymond Feng)".