tools: add more details about rolling inspector_protocol #57167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
legendecas
force-pushed
the
doc/inspector-protocol
branch
from
0ee06d9 to
f3d0312
Compare
aduh95
reviewed
Feb 23, 2025
| @@ -3,4 +3,35 @@ | |||
| This directory contains scripts to update the [Chromium inspector protocol][] | |||
| to local at `deps/inspector_protocol`. | |||
|
|
|||
| To run the `roll.py`, a local clone of the inspector_protocol project is required. | |||
| First, you will need to install Chromium's [depot_tools][], with `fetch` available | |||
There was a problem hiding this comment.
nit
Suggested change
| First, you will need to install Chromium's [depot_tools][], with `fetch` available | |
| First, you will need to install Chromium's [`depot_tools`][], with `fetch` available |
aduh95
reviewed
Feb 23, 2025
| First, you will need to install Chromium's [depot_tools][], with `fetch` available | ||
| in your `PATH`. | ||
|
|
||
| ```sh |
There was a problem hiding this comment.
Suggested change
| ```sh | |
| ```console |
aduh95
reviewed
Feb 23, 2025
| With a local clone of the inspector_protocol project up to date, run the following | ||
| commands to roll the dep. | ||
|
|
||
| ```sh |
There was a problem hiding this comment.
Suggested change
| ```sh | |
| ```console |
aduh95
reviewed
Feb 23, 2025
| @@ -3,4 +3,35 @@ | |||
| This directory contains scripts to update the [Chromium inspector protocol][] | |||
| to local at `deps/inspector_protocol`. | |||
|
|
|||
| To run the `roll.py`, a local clone of the inspector_protocol project is required. | |||
There was a problem hiding this comment.
Suggested change
| To run the `roll.py`, a local clone of the inspector_protocol project is required. | |
| To run the `roll.py`, a local clone of the `inspector_protocol` project is required. |
aduh95
reviewed
Feb 23, 2025
| /workspace/inspector_protocol/src $ git checkout main && git pull | ||
| ``` | ||
|
|
||
| With a local clone of the inspector_protocol project up to date, run the following |
There was a problem hiding this comment.
Suggested change
| With a local clone of the inspector_protocol project up to date, run the following | |
| With a local clone of the `inspector_protocol` project up to date, run the following |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instructions on how to run
tools/inspector_tools/roll.py.