NVDA now has the ability to report indents as tones, speech, or both. #5906 #6057

derekriemer · 2016-06-09T06:10:46Z

This is controlled by a combo box in document formatting.
Fixes #5906.

This is controlled by a combo box in document formatting.

jcsteh · 2016-06-09T10:33:50Z

source/config/__init__.py

@@ -19,6 +19,10 @@
 import easeOfAccess
 import winKernel

+#Constants for indent tones and speech.
+INDENT_SPEECH = 1
+INDENT_TONES = 2


nit: I totally get why you'd put these constants here, but I think I'd prefer to see them in the speech module. While we have to define the config spec here, I'd prefer to keep subsystem specific stuff with the subsystem as much as possible.

jcsteh · 2016-06-09T23:32:57Z

user_docs/en/userGuide.t2t

+- Tones
+- Speech
+- Both Speech and Tones
+


nit: Change this list ending to a dash on a line by itself rather than a blank line:

-

In changes.t2t, we use a double blank line because it's more natural when there are only lists, but in the User Guide, we use the dash method because lists are interspersed with other text, so it's clearer.

derekriemer · 2016-06-10T00:28:21Z

Done.

Re #6057.

jcsteh · 2016-06-10T11:46:12Z

#5906 is now incubated. Thanks for your work... and good job. :)

One final request for the future: please reference the issue in the comment when creating a PR. Note that if you reference it in the commit, it will be included in the default PR comment.

nvaccess#5906

@jcsteh

This no longer beeps with speech mode off. re nvaccess#5906 @jcsteh I haven't had time to update the user guide yet, I'll let you know when that's complete.

@jcsteh

@jcsteh considder this ready for further scrupulation.

jcsteh · 2016-07-01T12:55:42Z

source/config/__init__.py

@@ -178,6 +178,7 @@ def validateConfig(configObj,validator,validationResult=None,keyList=None):
 	reportPage = boolean(default=true)
 	reportLineNumber = boolean(default=False)
 	reportLineIndentation = boolean(default=False)
+	reportToneIndentation = boolean(default=False)


I think we should rename this to reportLineIndentationWithTones or lineIndentationTones, since it isn't clear that this is related to line indentation (as opposed to paragraph indentation).

derekriemer · 2016-07-02T20:58:30Z

Fixed

jcsteh · 2016-07-04T00:11:41Z

source/gui/settingsDialogs.py

@@ -1112,23 +1112,22 @@ def makeSettings(self, settingsSizer):
 		self.lineNumberCheckBox.SetValue(config.conf["documentFormatting"]["reportLineNumber"])
 		settingsSizer.Add(self.lineNumberCheckBox,border=10,flag=wx.BOTTOM)
 		sizer=wx.BoxSizer(wx.HORIZONTAL)
-		# Translators: This is the label for a combobox in the
+		# Translators: This is the label for a combobox controlling the line indentation in the


nit: "controlling the line indentation" -> "controlling the reporting of line indentation"

jcsteh · 2016-07-04T23:02:14Z

user_docs/en/userGuide.t2t

-This option allows you to configure how indentation at the beginning of lines is reported. The Report line indents with combo box has four options.
+==== Report line indentation with ====
+This option allows you to configure how indentation at the beginning of lines is reported.
+The Report line indents with combo box has four options.


You missed another instance of "Report line indents with" -> "Report line indentation with". :)

jcsteh · 2016-07-05T00:35:25Z

What's New entry: in New Features:

- NVDA can now indicate line indentation using tones. This can be configured using the "Report line indentation with" combo box in NVDA's Document Formatting preferences dialog. (#5906)

josephsl · 2016-07-07T00:17:25Z

Hi,

Found a major inconsistency/bug: if report indentation is off, pressing NVDA+F from an indented text does not announce indentation level.

STR:

Open Notepad++ or similar editor.
Using latest next build, set report indentation to off.
Type something into the editor and indent it.
Press NVDA+F.

Expected: NVDA announces indent level and type.
Actual: No announcement of indents.
Workaround: Need to set report indentation to speech, tone or both.

Note that this affects NVDA+F (report formatting). Thanks.

derekriemer · 2016-07-07T02:20:05Z

Wow, that happens because this didn't use to touch the config. Anyway,
I'll fix this.

On 7/6/2016 6:17 PM, Joseph Lee wrote:

Hi,

Found a major inconsistency/bug: if report indentation is off,
pressing NVDA+F from an indented text does not announce indentation level.

STR:

Open Notepad++ or similar editor.

Using latest next build, set report indentation to off.

Type something into the editor and indent it.

Press NVDA+F.

Expected: NVDA announces indent level and type.
Actual: No announcement of indents.
Workaround: Need to set report indentation to speech, tone or both.

Note that this affects NVDA+F (report formatting). Thanks.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6057 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFGivX3HeFS7nUlUTrHFj9N5cEL7wwljks5qTEWXgaJpZM4IxqMD.

Derek Riemer

Department of computer science, third year undergraduate student.
Proud user of the NVDA screen reader.
Open source enthusiast.
Member of Bridge Cu
Avid skiier.

Websites:
Honors portfolio http://derekriemer.com
Awesome little hand built weather app!
http://django.derekriemer.com/weather/

email me at [email protected] mailto:[email protected]
Phone: (303) 906-2194

* The code for playing a tone was actually surprisingly indented two tabs, rahter than one tab. It worked in all cases except a few, I.E. 18 tabs, and then 3 spaces. This is now fixed, and indents work as expected.

derekriemer · 2016-07-14T15:12:18Z

@michaelDCurran Is this going to incubate into next in time for 16.3?

On 7/6/2016 6:17 PM, Joseph Lee wrote:

Hi,

Found a major inconsistency/bug: if report indentation is off,
pressing NVDA+F from an indented text does not announce indentation level.

STR:

Open Notepad++ or similar editor.

Using latest next build, set report indentation to off.

Type something into the editor and indent it.

Press NVDA+F.

Expected: NVDA announces indent level and type.
Actual: No announcement of indents.
Workaround: Need to set report indentation to speech, tone or both.

Note that this affects NVDA+F (report formatting). Thanks.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6057 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFGivX3HeFS7nUlUTrHFj9N5cEL7wwljks5qTEWXgaJpZM4IxqMD.

Derek Riemer

Department of computer science, third year undergraduate student.
Proud user of the NVDA screen reader.
Open source enthusiast.
Member of Bridge Cu
Avid skiier.

Websites:
Honors portfolio http://derekriemer.com
Awesome little hand built weather app!
http://django.derekriemer.com/weather/

email me at [email protected] mailto:[email protected]
Phone: (303) 906-2194

michaelDCurran · 2016-07-18T00:51:26Z

Sorry: but now NVDA+f does not work. reportLineSpacing is missing from the reportFormatting dict.

derekriemer · 2016-07-18T17:32:49Z

Fixed, I'm sorry I missed that.

On 7/17/2016 6:51 PM, Michael Curran wrote:

Sorry: but now NVDA+f does not work. reportLineSpacing is missing from
the reportFormatting dict.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#6057 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFGivWGUvts7Bjj7tNcwjAEWbjpnaONkks5qWs4QgaJpZM4IxqMD.

Derek Riemer

Department of computer science, third year undergraduate student.
Proud user of the NVDA screen reader.
Open source enthusiast.
Member of Bridge Cu
Avid skiier.

Websites:
Honors portfolio http://derekriemer.com
Awesome little hand built weather app!
http://django.derekriemer.com/weather/

email me at [email protected] mailto:[email protected]
Phone: (303) 906-2194

NVDA now has the ability to report indents as tones, speech, or both.

149618a

This is controlled by a combo box in document formatting.

jcsteh reviewed Jun 9, 2016
View reviewed changes

fix code review comments from @jcsteh

f2ca50f

jcsteh reviewed Jun 9, 2016
View reviewed changes

fix comments made about user guide.

088aa58

jcsteh added a commit that referenced this pull request Jun 10, 2016

Merge branch 'i5906' into next

5859154

Re #6057.

derekriemer added 4 commits June 10, 2016 09:33

NVDA now properly speaks "no indent" only while speech is turned on. re

b899f9c

nvaccess#5906

This is now controlled by two text boxes.

6111c4a

This no longer beeps with speech mode off. re nvaccess#5906 @jcsteh I haven't had time to update the user guide yet, I'll let you know when that's complete.

Make the gui One list. Re: nvaccess#5906 CC @jcsteh

73809fd

User guide reflects code changes. re: nvaccess#5906

6d6ee04

@jcsteh considder this ready for further scrupulation.

jcsteh reviewed Jul 1, 2016
View reviewed changes

jcsteh reviewed Jul 4, 2016
View reviewed changes

More review complete cc @jcsteh

ea7dca0

jcsteh reviewed Jul 4, 2016
View reviewed changes

Fixed all "indents" -> indentation

b8518d8

jcsteh added a commit that referenced this pull request Jul 5, 2016

Incubates #6057

53ac625

nvaccessAuto added the incubating label Jul 5, 2016

nvaccessAuto assigned jcsteh Jul 5, 2016

derekriemer added 3 commits July 6, 2016 21:02

Fix bug with report formatting script.

0e3d671

Fix copyright header.

954021a

Fix indentation error.

f6d5361

* The code for playing a tone was actually surprisingly indented two tabs, rahter than one tab. It worked in all cases except a few, I.E. 18 tabs, and then 3 spaces. This is now fixed, and indents work as expected.

derekriemer changed the title ~~NVDA now has the ability to report indents as tones, speech, or both.~~ NVDA now has the ability to report indents as tones, speech, or both. #5906 Jul 7, 2016

derekriemer added 3 commits July 11, 2016 16:39

remove grammar errors.

a4bf2c7

Fix merge conflicts.

19ea949

Merge remote-tracking branch 'nvaccess/master' into i5906

539cfb9

Fix broken lineSpacing in formatConfig

f3a84f1

michaelDCurran added a commit that referenced this pull request Aug 1, 2016

Incubates #6057

35964ac

nvaccessAuto assigned michaelDCurran and unassigned jcsteh Aug 1, 2016

jcsteh merged commit 3aa65e1 into nvaccess:master Aug 29, 2016

jcsteh added this to the 2016.4 milestone Aug 29, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NVDA now has the ability to report indents as tones, speech, or both. #5906 #6057

NVDA now has the ability to report indents as tones, speech, or both. #5906 #6057

derekriemer commented Jun 9, 2016 •

edited by jcsteh

Loading

jcsteh Jun 9, 2016

jcsteh Jun 9, 2016

derekriemer commented Jun 10, 2016

jcsteh commented Jun 10, 2016

jcsteh Jul 1, 2016

derekriemer commented Jul 2, 2016

jcsteh Jul 4, 2016

jcsteh Jul 4, 2016

jcsteh commented Jul 5, 2016

josephsl commented Jul 7, 2016

derekriemer commented Jul 7, 2016

derekriemer commented Jul 14, 2016

michaelDCurran commented Jul 18, 2016

derekriemer commented Jul 18, 2016

NVDA now has the ability to report indents as tones, speech, or both. #5906 #6057

NVDA now has the ability to report indents as tones, speech, or both. #5906 #6057

Conversation

derekriemer commented Jun 9, 2016 • edited by jcsteh Loading

jcsteh Jun 9, 2016

Choose a reason for hiding this comment

jcsteh Jun 9, 2016

Choose a reason for hiding this comment

derekriemer commented Jun 10, 2016

jcsteh commented Jun 10, 2016

jcsteh Jul 1, 2016

Choose a reason for hiding this comment

derekriemer commented Jul 2, 2016

jcsteh Jul 4, 2016

Choose a reason for hiding this comment

jcsteh Jul 4, 2016

Choose a reason for hiding this comment

jcsteh commented Jul 5, 2016

josephsl commented Jul 7, 2016

derekriemer commented Jul 7, 2016

derekriemer commented Jul 14, 2016

michaelDCurran commented Jul 18, 2016

derekriemer commented Jul 18, 2016

derekriemer commented Jun 9, 2016 •

edited by jcsteh

Loading