-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unused networkname props #562
base: master
Are you sure you want to change the base?
fix: remove unused networkname props #562
Conversation
🦋 Changeset detectedLatest commit: cf6f57d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for fixing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need to be removed from createIcon
as well?
react-share/src/hocs/createIcon.tsx
Line 13 in 944d26f
networkName: string; |
"next": "^15.1.6", React does not recognize the networkName prop on a DOM element. Please tell me how to fix this error. |
@bkjohnson I don't think so. From what I saw, it is used in |
@Genevy No fix has been merged for now, you need to downgrade to : |
@lcouellan Thanks! |
any update into merging fix? Downgrading to 5.1.2 did not remove the warning for me. |
Version to fix: v5.2.0
Incriminated commit: d172111
Description of the changes: I removed
networkname
Props ofCreateShareButton
component since the props was not used anymore and rendered in the DOM.Screenshot of the DOM before my changes:

Screenshot of the DOM after my changes:

Screenshots were taken from React Share Demo