Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused networkname props #562

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lcouellan
Copy link

@lcouellan lcouellan commented Feb 3, 2025

Version to fix: v5.2.0

Incriminated commit: d172111

Description of the changes: I removed networkname Props of CreateShareButton component since the props was not used anymore and rendered in the DOM.

Screenshot of the DOM before my changes:
Screenshot from 2025-02-03 10-46-54

Screenshot of the DOM after my changes:
Screenshot from 2025-02-03 10-46-29

Screenshots were taken from React Share Demo

Copy link

changeset-bot bot commented Feb 3, 2025

🦋 Changeset detected

Latest commit: cf6f57d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-share Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@CuriouslyCory CuriouslyCory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for fixing this!

Copy link

@bkjohnson bkjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to be removed from createIcon as well?

networkName: string;

@Genevy
Copy link

Genevy commented Feb 11, 2025

"next": "^15.1.6",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"react-router-dom": "^7.1.1",
"react-share": "^5.2.0"

React does not recognize the networkName prop on a DOM element.

Please tell me how to fix this error.

@lcouellan
Copy link
Author

@bkjohnson I don't think so. From what I saw, it is used in CreateIcon component.

@lcouellan
Copy link
Author

"next": "^15.1.6", "react": "^19.0.0", "react-dom": "^19.0.0", "react-router-dom": "^7.1.1", "react-share": "^5.2.0"

React does not recognize the networkName prop on a DOM element.

Please tell me how to fix this error.

@Genevy No fix has been merged for now, you need to downgrade to : react-share: ^5.1.2

@Genevy
Copy link

Genevy commented Feb 11, 2025

@lcouellan Thanks!

@Strutsagget
Copy link

any update into merging fix? Downgrading to 5.1.2 did not remove the warning for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants